Skip to content

feat(incremental): ignore AWS CDK synth output#635

Merged
tirth8205 merged 1 commit into
mainfrom
codex/port-cdk-ignore
Jul 17, 2026
Merged

feat(incremental): ignore AWS CDK synth output#635
tirth8205 merged 1 commit into
mainfrom
codex/port-cdk-ignore

Conversation

@tirth8205

Copy link
Copy Markdown
Owner

What changed

  • Ignore AWS CDK cdk.out synth artifacts at the repository root and inside monorepo packages.
  • Add regression coverage for root, nested, and similarly named non-artifact directories.
  • Keep *.bundle.js out of the built-in defaults because users cannot negate a default ignore pattern.

Why

This ports only the safe, current-main-compatible part of Gideon Zenz's PR #335 (commit 448e48c). CDK synth output is generated code that should not pollute the graph, while a global bundle-file default would be irreversible for repositories that intentionally track those files.

Gideon Zenz is preserved as co-author on the commit.

Validation

  • TDD red: the new CDK regression failed on current main because cdk.out/manifest.json was not ignored.
  • Focused ignore suite: 9 passed.
  • Full suite after rebase: 1489 passed, 2 xpassed.
  • CI lint scope: ruff check code_review_graph/ passed.
  • Changed-file lint and git diff --check passed.
  • Knowledge-graph review found no affected execution flows; the change is limited to the default ignore constant and its regression test.

@github-actions

Copy link
Copy Markdown

code-review-graph review

Overall risk: 0.25 (LOW) — 2 changed function(s)/class(es), 0 affected flow(s), 1 test gap(s)

Risk-scored changes

Risk Level Symbol Location Tested
0.25 low tests/test_incremental.py::TestIgnorePatterns.test_cdk_output_default_matches_at_any_depth tests/test_incremental.py:271 (test)
0.20 low tests/test_incremental.py::TestIgnorePatterns tests/test_incremental.py:188 no

Test gaps

  • tests/test_incremental.py::TestIgnorePatterns (tests/test_incremental.py:188)

Token savings: this graph-backed report used ~20,075 fewer tokens (~97%) than reading every changed file in full (estimated, chars/4 approximation).


Powered by code-review-graph — local-first analysis; no code leaves the CI runner.

Port the safe cdk.out portion of PR #335 (commit 448e48c) with explicit root, nested-monorepo, and similarly-named-directory coverage. The irreversible *.bundle.js default is intentionally excluded.

Co-authored-by: Gideon Zenz <91069374+gzenz@users.noreply.github.com>
@tirth8205
tirth8205 force-pushed the codex/port-cdk-ignore branch from f121ca2 to e5abee2 Compare July 17, 2026 14:48
@tirth8205
tirth8205 merged commit 52ce742 into main Jul 17, 2026
11 checks passed
@tirth8205
tirth8205 deleted the codex/port-cdk-ignore branch July 17, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant