Repository navigation
Float the base images and update packages at build time - #1
Merged
Merged
Conversation
Both stages were pinned by digest, so they never picked up rebuilt bases. The web server moves from nginx 1.22 to 1.26: the 1.22 image is no longer rebuilt, so floating it would gain nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alex O'Regan <alex.oregan@tigera.io>
A floating base only helps once the registry rebuilds it; updating at build time also picks up errata released since. The update reverts /var/log/nginx to the nginx package's root:root ownership, so the base image's chown is re-applied before dropping back to uid 1001. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alex O'Regan <alex.oregan@tigera.io>
The update layer was served from the build cache whenever the base image was unchanged, so the image could ship updates days old. Declaring BUILD_DATE ahead of the update makes it re-run when the build passes a new value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alex O'Regan <alex.oregan@tigera.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alex O'Regan <alex.oregan@tigera.io>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Image build workflows must pass a changing BUILD_DATE to ensure package updates rerun.
Review effort: Lite
Findings: 1
What changed in this PR
Updates container base images, applies runtime package updates, and refreshes dependency resolutions.
Changes:
- Floats UBI Node.js and nginx base images.
- Adds runtime package updates and restores nginx log permissions.
- Updates dependency lockfile entries.
| File | Summary |
|---|---|
package-lock.json |
Refreshes dependency resolutions and metadata. |
build/Containerfile |
Floats images and adds runtime package updates; build paths do not pass BUILD_DATE, so updates may remain cached. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+25
to
+28
| # BUILD_DATE differs on every build, so declaring it here re-runs the package | ||
| # update rather than reusing a cached layer from an earlier build. | ||
| ARG BUILD_DATE=unknown | ||
| RUN dnf -y update && \ |
anthonytwh
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📝 Links
release-2.12line (consoles up to 4.21): Float the base images and update packages at build time (release-2.12) #2📝 Description
Brings the image up to date and keeps it there.
ubi9/nodejs-22:latest; the web server moves fromnginx-122toubi9/nginx-126:latest, because the 1.22 image has not been rebuilt since January and floating it would gain nothing./var/log/nginxto the package'sroot:root 0711, discarding the base image's ownership for uid 1001 — without restoring it, the container crash-loops on startup — so the ownership is re-applied before dropping back to uid 1001.BUILD_DATEis declared ahead of the update; builds pass a new value each time.npm audit fix). Shipped dependencies go from 3 high to 2; the remaining two (react-router, via the console SDK) are only fixed in an SDK 4.23 prerelease.Only
build/Containerfileandpackage-lock.jsonchange;build/Containerfile-downstreamis untouched.🎥 Demo
Built and run locally:
/var/log/nginxowned by1001:0; RHEL 9.8, nginx 1.26.3;plugin-manifest.jsonserved (HTTP 200).__load_plugin_entry__("forklift-console-plugin", …).BUILD_DATEtwice leaves the update cached; a new value makes it re-run.📝 CC://
🤖 Generated with Claude Code