Repository navigation
Pull base images and reference BUILD_DATE in the package update - #5
Merged
Merged
Conversation
Docker re-runs a RUN when an ARG declared ahead of it changes, but other builders need the value used in the instruction itself. Referencing it makes the update re-run on every build whichever builder is used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alex O'Regan <alex.oregan@tigera.io>
The podman build reused any local copy of a floating base tag and never passed BUILD_DATE, so it could build on a stale base and reuse a cached package update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alex O'Regan <alex.oregan@tigera.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Links
release-2.12line (consoles up to 4.21): Pull base images and reference BUILD_DATE in the package update (release-2.12) #6📝 Description
Makes sure the package update in the image actually runs, on a current base, however the image is built.
BUILD_DATEin the package update. Docker re-runs aRUNwhen anARGdeclared ahead of it changes, but other builders — including podman, whichci/build-and-push-images.shuses — need the value used in the instruction itself. The update now echoes it.BUILD_DATE. It reused any local copy ofnginx-126:latestwithout checking the registry and never passedBUILD_DATE, so it could build on a stale base and reuse a cached update.Not changed: the
on-push-mainandon-push-releaseworkflows publish to upstream'squay.io/kubev2v, do not run on this fork, and build on fresh runners with no layer cache, so the update already runs there.🎥 Demo
Built with
docker build --pulland run locally:nginx-126(build date 2026-09-30).BUILD_DATEtwice leaves the update cached; a new value makes it re-run./var/log/nginxowned by1001:0, 4.22 loader__load_plugin_entry__("forklift-console-plugin", …), no package updates pending.The podman script path is untested (podman is not installed here).
📝 CC://
🤖 Generated with Claude Code