Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-3397] - Mobile Responsiveness V1 #1505
[WEB-3397] - Mobile Responsiveness V1 #1505
Changes from all commits
88d5cd9
4d253cb
0a4a482
e02793f
000576e
edbf0a8
91f45ac
d28fdb3
1d584e4
529df9e
cf3765f
e2188aa
16ef391
bc29597
aa08eb6
6ebe49e
19d00b5
dda188e
2d2cf15
53ff470
0fa7c24
d1922f3
d5c7907
df3e597
d0b017f
68f8c0e
d8891db
b4e2e49
7a32305
50da716
3585af1
edea64d
3a10904
da65a71
c382ee3
c8e1b06
05d5be8
3ebfc26
5e33a06
1577a4a
79c49ba
5dae4d8
4297290
454f563
818661e
c91a42f
06644af
9cfb712
7baa92a
df8cbac
637869c
e804a59
36c2686
d83712f
3f0c372
ea74eaf
68e232d
e1af8f3
9ca63ca
48b5b3c
c96e66e
b720c8f
94bec1b
a7cf589
2835768
1854f82
9788e80
84cc459
585a0c6
54271e5
47e2d5d
e5a231a
ecdf6ca
b579529
d607d23
59b3596
cc802af
7e56073
5f4db0d
8eeb751
cb40b15
877208f
f9a1d5e
1456692
12a4285
3aa75b8
54eb2a2
3b7af11
5a970f4
00e12ee
96b087f
9bc33ff
73ee8c2
573ac62
c74ef54
9a6c122
d33a07d
940a7a8
e8e2eb7
ed8395a
09696f4
d68affc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have insight on why only these two chart types are able to launch the chart range modal, I'm curious to know. Sharon and Bill were unsure as well (discussion thread). I have duplicated this restriction for the mobile view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't recall all the details, but it would have been a product decision many years ago. Likely, the addition of selectable data ranges were added one at a time, (basics first, then daily, IIRC). It was probably due to just trying to get features developed and tested quickly. Most of blips early years took a much more MVP approach to development, and new features were not added hastily.
Now, it would be trivial to add it to BG log at some point, but likely no request ever came in for it. For trends, it has it's own unique date range select UI built in, so I think product and design needed to give more thought as to whether or not it made sense to add a secondary date selection means to Trends, or replace what we have.