Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3397] - Mobile Responsiveness V1 #1505

Open
wants to merge 100 commits into
base: develop
Choose a base branch
from
Open

Conversation

henry-tp
Copy link
Contributor

@henry-tp henry-tp commented Jan 23, 2025

@henry-tp henry-tp changed the base branch from develop to WEB-3274-device-settings-data-sources January 23, 2025 23:00
@henry-tp henry-tp changed the title [WEB-3397] - Mobile Responsiveness [WEB-3397] - Mobile Responsiveness V1 Jan 23, 2025
Base automatically changed from WEB-3274-device-settings-data-sources to develop January 27, 2025 14:47
@henry-tp
Copy link
Contributor Author

henry-tp commented Feb 3, 2025

Thanks for the review @clintonium-119 . After your review, there are two remaining things I could use your help on:

  1. How to replace the setInitialChartView() call and make it work to derive the chart based on patient's data sources
  2. Decision on the best approach to maintain patient context in the nav bar without risking pulling the wrong patient's data

If you have time to pair on this, that would be much appreciated, or we can figure it out however else

EDIT: Above resolved


const isClinicContext = !!selectedClinicId;
const isUserPatient = personUtils.isSame(user, patient);
const canViewDevices = isClinicContext || isUserPatient;
Copy link
Contributor Author

@henry-tp henry-tp Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clintonium-119

I have implemented the changes from our video discussion, first about calling setInitialChartView and second to ensure that the Private Workspace still clears the currentPatientInViewId.

Last consequential change I have made is this restriction on who sees a button to view the Device Settings. The isClinicContext || isUserPatient condition is a mirror of yours used to render the "Connect a Device" card.

Thanks for all of your effort in review 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants