-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-3397] - Mobile Responsiveness V1 #1505
base: develop
Are you sure you want to change the base?
Conversation
This reverts commit 1456692.
Thanks for the review @clintonium-119 . After your review, there are two remaining things I could use your help on:
If you have time to pair on this, that would be much appreciated, or we can figure it out however else EDIT: Above resolved |
…into WEB-3397-mobile-views
|
||
const isClinicContext = !!selectedClinicId; | ||
const isUserPatient = personUtils.isSame(user, patient); | ||
const canViewDevices = isClinicContext || isUserPatient; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have implemented the changes from our video discussion, first about calling setInitialChartView
and second to ensure that the Private Workspace still clears the currentPatientInViewId
.
Last consequential change I have made is this restriction on who sees a button to view the Device Settings. The isClinicContext || isUserPatient
condition is a mirror of yours used to render the "Connect a Device" card.
Thanks for all of your effort in review 😓
WEB-3397