♻️ refactor: 공통 컴포넌트, hook 이동 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- components/common -> common/components - 공통 컴포넌트 이동하면서 추가적으로 생긴 경로 변경 반영
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- application/hooks/common -> common/hooks - 공통 hook 이동하면서 추가적으로 생긴 경로 변경 반영
- application/util -> common/utils - 경로 수정으로 추가적인 변경 반영
- infra/sdk -> common/libs - 경로 변경으로 인한 추가적인 경로 수정
|
빌드 에러 발생하는거 해결하고 있으니 다른거 먼저 리뷰 해주세요~ |
SeieunYoo
approved these changes
Jun 15, 2023
Comment on lines
+3
to
+5
| import { Button } from "../../Button"; | ||
| import { Icon } from "../../Icon"; | ||
| import { RandomImage } from "../../RandomImge"; |
There was a problem hiding this comment.
여기서는 절대경로 적용 안되나유 ? @common/components/~
There was a problem hiding this comment.
vscode 자동완성 import 로 저게 나와서 그렇긴 합니다
common/components 폴더 안에 있는 컴포넌트 끼리는 절대경로가 추천이 안되더라구요 ㅜㅜ
elbica
reviewed
Jun 17, 2023
아직 feature 폴더 작업은 안했어요~ |
- twin.macro 를 import하는 파일 목록을 src 폴더 내에 있는 모든 폴더로 수정 - https://github.com/ben-rogerson/twin.examples/blob/master/next-emotion/withTwin.js
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
⛳️ 작업 내용
🌱 PR 포인트
refactor/issue-53마더 브랜치를 만든 후 이 브랜치에 RFC: FDA(Feature-Driven Architecture) 기반 폴더 구조 변경 및 react-query 구조 개선 #53 에 대한 작업을 모두 완료 한 후 최종적으로 develop으로refactor/issue-53브랜치를 merge 합니다.components/common->common/componentsapplication/hooks/common->common/hooksapplication/util->common/utilsinfra/sdk->common/libs