♻️ Refactor: 폴더 구조 변경 및 react-query 구조 개선 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- components/common -> common/components - 공통 컴포넌트 이동하면서 추가적으로 생긴 경로 변경 반영
- application/hooks/common -> common/hooks - 공통 hook 이동하면서 추가적으로 생긴 경로 변경 반영
- application/util -> common/utils - 경로 수정으로 추가적인 변경 반영
- infra/sdk -> common/libs - 경로 변경으로 인한 추가적인 경로 수정
- twin.macro 를 import하는 파일 목록을 src 폴더 내에 있는 모든 폴더로 수정 - https://github.com/ben-rogerson/twin.examples/blob/master/next-emotion/withTwin.js
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- /components/home -> /features/home/components - deadcode 삭제
- /components/meme -> /features/memes/components - deadcode 삭제 - feature간에 공통으로 쓰이는 컴포넌트는 /features/common 에 배치
- /components/mypage -> /features/mypage/components
- /components/collect -> /features/collect/components
- /components/search -> /features/search/components
- /components/tags -> /features/explore/tags/components - /components/keywords -> /features/explore/keywords/components - TagCategory 컴포넌트는 공통 컴포넌트로 /feature/common 으로 이동
- /components/share -> /features/share/components
- /components/hocs -> /features/common/hocs
- /application/hooks/domain -> /features/common/hooks
- /application/hooks/domain -> /features/common/hooks
- /application/hooks/api/core -> /api/core - useCoreInfiniteQuery 추후 리팩터링 시 삭제 예정
- /infra/api/index.ts -> /api/core/axios.ts - /infra/api/index.ts 삭제 예정
- /application/hooks/api/meme -> /api/meme
- /application/hooks/api/tags -> /api/tag
- /application/hooks/api/collection -> /api/collection
- /application/hooks/api/search -> /api/search - useGetUserFindMemes(회원이 찾는 밈 API) 삭제(dead code)
- /application/hooks/api/account -> /api/account
- /application -> /api/core - DefaultPageProps 타입을 /api/core/query-client.tsx 로 이동
- /api/core/axios.ts 로 이동함
- 관리 되지 않는 Navigation, Category, Sidebar 스토리북 삭제 - 위 스토리북 코드에서 오류 발생으로 삭제함 - preview.js에 OverlayProvider 추가
스토리북 빌드 오류 발생
스토리북 빌드 결과 스토리북 빌드 오류 해결 방식
|
ojj1123
changed the title
ojj1123
changed the title
ojj1123
changed the title
SeieunYoo
approved these changes
Jul 24, 2023
@SeieunYoo 따로 관리하는건 아니고 인증/인가 설계랑 엮기는 부분이 있어서 일단 그대로 두었습니다~ 기능상 문제는 없어서 일단은 두었고 다시 리팩터링을 해보려고 합니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
🌱 PR 포인트
tailwind.config.js수정📸 스크린샷