Added more detailed tabline configuration options #21
Conversation
lua/kanagawa-paper/themes.lua
Outdated
| win_separator = palette.dragonViolet, | ||
| indent = palette.sumiInk5, | ||
| indent_scope = palette.dragonViolet, | ||
| picker = palette.dragonRed, | ||
| scrollbar = palette.fujiGray, | ||
| tabline = { | ||
| bg = palette.sumiInk0, | ||
| fg_selected = palette.sumiInk3, |
There was a problem hiding this comment.
for consistency across the different tabline/bufferline plugins, can we change the selected and inactive fg/bg colors to match the existing ones?
you can see plugins.lua BufferCurrent and BufferInactive as reference
I know theyre not as bright as the ones youve suggested here. Id rather keep the defaults consistent and not drastically change them on people, and instead have users override in their personal configs to their own taste
There was a problem hiding this comment.
No problem. I've reset these to the default colors in 96333b9, although I think the default for the selected tab needs to be adjusted. Maybe we could set the foreground to the theme foreground color fujiWhite?
Example:
Here themes.lua is the selected tab and plugins.lua is an inactive tab.
There was a problem hiding this comment.
you might be looking at a different hlgroup. I think the defaults would make the values this? how does that look?
tabline = {
bg = palette.sumiInk0,
fg_selected = palette.dragonWhite,
bg_selected = palette.sumiInk3,
fg_inactive = palette.dragonBlack5,
bg_inactive = palette.sumiInk0,
},
current defaults:
BufferCurrent = { link = "BufferlineBufferSelected" },
BufferlineBufferSelected = { bg = theme.ui.bg, fg = palette.dragonWhite, bold = true },
BufferInactive = { link = "BufferlineBuffer" },
BufferlineBuffer = { bg = theme.ui.bg_tabline, fg = theme.ui.fg_dim, bold = false },
on my screen, with barbar, the theme looks like this, where colors is the selected, and the others are inactive:
There was a problem hiding this comment.
oh I see what happened - youre using the colors from the previous TabLine hlgroup
sorry I wasnt clear - I was meaning that we should make BufferCurrent/BufferInactive/etc the default colors, set those in your new tabline table. then update Tabline/BufferCurrent/etc to use your new table
the old TabLine hlgroup colors were not great at all
There was a problem hiding this comment.
These are the settings that were previously in editor.lua:
-- TabLine Tab pages line, not active tab page label.
TabLine = { bg = theme.ui.bg_tabline, fg = theme.ui.special },
-- TabLineFill Tab pages line, where there are no labels.
TabLineFill = { bg = theme.ui.bg_tabline },
-- TabLineSel Tab pages line, active tab page label.
TabLineSel = { fg = theme.ui.fg_dim, bg = theme.ui.bg_p1 },Which makes the colors using the new config I introduced this:
tabline = {
bg = palette.sumiInk0, -- bg_tabline
fg_selected = palette.dragonBlack5, -- fg_dim
bg_selected = palette.sumiInk4, -- bg_p1
fg_inactive = palette.springViolet1, -- special
bg_inactive = palette.sumiInk0, -- bg_tabline
},Although it seems you're suggesting to use the colors configured for barbar as the "default". Is that right?
There was a problem hiding this comment.
Although it seems you're suggesting to use the colors configured for
barbaras the "default". Is that right?
thats correct
There was a problem hiding this comment.
I've applied your suggestion in 360eef3.
Looks good to me!
I was meaning that we should make BufferCurrent/BufferInactive/etc the default colors, set those in your new tabline table. then update Tabline/BufferCurrent/etc to use your new table.
I thought you might ask for this 😆. It seems like the two configured tabline plugins are BufferLine and barbar. Are there any others? I'll update those configurations later today.
There was a problem hiding this comment.
those 2 + MiniTabline are the only ones I think
https://github.com/echasnovski/mini.tabline/blob/main/doc/mini-tabline.txt#L48
With default settings, I had an issue where the selected tab was difficult to read:
The more I dug into it, the more control I wanted over the selected and inactive tab colors.
Thanks for the great theme!