Skip to content

Fix options menu memory access violation on localization change #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ProfLander wants to merge 2 commits into
base: all-in-one-vs2022-wpo
Choose a base branch
from
Draft

Fix options menu memory access violation on localization change #368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dae2b3a
Fix options menu MAVs on localization change
ProfLander Sep 11, 2025
d44f3ba
Move options MAV fix to `_g_patches`, remove `ui_options.options` man…
ProfLander Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion gamedata/scripts/_g_patches.script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,4 +690,30 @@ _G.log = function(str)
if DebuggerMode then
LuaPanda.printToVSCode(str,1,2)
end
end
end

-- Lander:
-- Prevent ui_options.UIOptions from addressing self.owner (the main menu)
-- after localization reload. This causes MAVs, as the main menu gets xr_delete'd
-- and replaced with a fresh instance before option change callbacks finish running.

--- Localization reload flag
local loc_reloaded = false

--- Patch `func_localization` to set the reload flag
local old_funct = ui_options.func_localization
function ui_options.func_localization(...)
loc_reloaded = true
return old_funct(...)
end

--- Patch `UIOptions:On_Cancel` to reset the reload flag and early-return if it is set
local old_cancel = ui_options.UIOptions.On_Cancel
function ui_options.UIOptions.On_Cancel(self, ...)
if loc_reloaded then
loc_reloaded = false
self.owner = nil
else
return old_cancel(self, ...)
end
end
Loading