Fix options menu memory access violation on localization change

[ProfLander]

Adds a monkey-patch for ui_options.script to prevent it from accessing a deleted self.owner after localization is reset.

Closes #367.

[ravenascendant]

patch timing is wrong. option table navigation is unnecessary if the functor is patched before the table is built.

[themrdemonized]

patch timing is wrong. option table navigation is unnecessary if the functor is patched before the table is built.

What you think if we put this change into ui_options.script itself and add this into the next exes version?

[ravenascendant]

patch timing is wrong. option table navigation is unnecessary if the functor is patched before the table is built.

What you think if we put this change into ui_options.script itself and add this into the next exes version?

Are any of the pre MCM mods that replaced UI options still a thing? warfare overhaul? dynamic mutants?

other than the risk of being over written, which is probably small (?) moving all your options changes to a script replacement does make sense.

[ProfLander]

Adopting ui_options into modded exes sounds good to me; I've drafted the PR while the question is open.

@ravenascendant How extensive are MCM's changes to ui_options? If xray-monolith is going to adopt the script as first-class gamedata, it would be preferable for that version to be the single source of truth, with downstream additions coming in via monkey patch.

We could break apart larger functions, or add new patch entrypoints within them if the current structure is too monolithic for that to be tractable as-is. Though I suppose that would raise the question of compatibility with vanilla 🤔

[ravenascendant]

Adopting ui_options into modded exes sounds good to me; I've drafted the PR while the question is open.

@ravenascendant How extensive are MCM's changes to ui_options? If xray-monolith is going to adopt the script as first-class gamedata, it would be preferable for that version to be the single source of truth, with downstream additions coming in via monkey patch.

We could break apart larger functions, or add new patch entrypoints within them if the current structure is too monolithic for that to be tractable as-is. Though I suppose that would raise the question of compatibility with vanilla 🤔

MCM doesn't use anything in ui_options.script

ui_mcm.script started as a lazy copy and rename of ui_options.script with a dynamic options table loader tacked on. I have since expanded upon it in many ways. "lazy" code duplication saves me from being affected by changes to ui_options.script
However bugs involving ui_options are likely to behave similarly with MCM because the structure and a majority of the code is still the same.

it uses some of the same textures and texture definitions. and some translation strings. eventually i will duplicate these into MCM since i know that Tronex made a new options UI for anomaly 1.6 and i don't want to be dependant on file that could be deleted or changed becaue of that.

if ui_options does become part of modded exe's i will submit a PR for the ui_options bugs that i have fixed in MCM. maybe open an issue for the ones i can't figure out how to fix. ;P

[ProfLander]

MCM doesn't use anything in ui_options.script

Gah, sorry; I got ui_main_menu.script mixed up with ui_options.script. Ran into an MO2 conflict with it in the early stages of debugging this PR, and the wrong one stuck in my head. No worries on that front then.