Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function: add support for more functions #142

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

GiedriusS
Copy link
Member

Add various math functions and tests for them. Fix fuzzing test to ignore functions that do not consume a matrix.

Add various math functions and tests for them. Fix fuzzing test to
ignore functions that do not consume a matrix.
@GiedriusS GiedriusS marked this pull request as ready for review January 5, 2023 15:00
Copy link
Collaborator

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

I think we might want to reorganize tests a bit in the future, we seem to have accumulated lots of repetitive code and it's hard to know what is now tested and what isnt.

@GiedriusS
Copy link
Member Author

Good point, I've created #144 for this.

@GiedriusS GiedriusS merged commit a831c7b into main Jan 6, 2023
@GiedriusS GiedriusS deleted the add_more_functions branch January 6, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants