-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize function tests #144
Comments
I'd love to help with this, what way of reorganizing do you suggest? @GiedriusS @fpetkovski |
First thing I would suggest is merging instant and range query tests, so that we add test cases in only one place. I would look into how we can define multiple expressions in a test case for a single |
I was thinking maybe we could cover more cases in the fuzzer https://github.com/thanos-community/promql-engine/blob/main/engine/enginefuzz_test.go#L21 and we could remove simple cases from that testing function #142 (review). |
/assign |
I wonder, why does the |
Up until recently we had no support for NaN comparisons since there are many different ways to represent a NaN in go. We could it it now though, and use |
#142 (review)
With lots of functions, it's hard to understand what is being tested and what is not. Reorganize the tests to make them clearer.
The text was updated successfully, but these errors were encountered: