Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid update state transition #1835

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Feb 19, 2025

This test (which was attempting to trigger an NDE)

cd internal/cmd/build
go run . integration-test -run='TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound'

yields

received *update.Acceptance message while in state Completed
2025/02/19 17:35:53 Running /opt/homebrew/bin/go in /Users/dan/src/temporalio/sdk-go/test with args [test -count 1 -race -v -timeout 10m -run TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound ./...]
# go.temporal.io/sdk/test.test
ld: warning: '/private/var/folders/d2/hflhkhsd08v8nbjf3jf9yfdm0000gn/T/go-link-2427899778/000018.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
=== RUN   TestIntegrationSuite
=== RUN   TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound
2025/02/19 17:35:55 INFO  Started Worker Namespace integration-test-namespace TaskQueue tq-b66e3a7c-165c-4715-86ed-7cade72dc90b-TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound WorkerID [email protected]@
2025/02/19 17:35:55 DEBUG NewTimer Namespace integration-test-namespace TaskQueue tq-b66e3a7c-165c-4715-86ed-7cade72dc90b-TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound WorkerID [email protected]@ WorkflowType NonDeterminismCommandNotFoundWorkflow WorkflowID test-non-determinism-failure-cause-command-not-found-21993cd9-39ea-490f-bd2e-76c038195659 RunID 0195205a-7cc5-7ee4-9b6f-47c9dc47626b Attempt 1 TimerID 7 Duration 999h0m0s
2025/02/19 17:35:55 WARN  Failed to poll for task. Namespace integration-test-namespace TaskQueue tq-b66e3a7c-165c-4715-86ed-7cade72dc90b-TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound WorkerID [email protected]@ WorkerType WorkflowWorker Error worker stopping
2025/02/19 17:35:55 INFO  Stopped Worker Namespace integration-test-namespace TaskQueue tq-b66e3a7c-165c-4715-86ed-7cade72dc90b-TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound WorkerID [email protected]@
2025/02/19 17:35:55 INFO  Started Worker Namespace integration-test-namespace TaskQueue tq-b66e3a7c-165c-4715-86ed-7cade72dc90b-TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound WorkerID [email protected]@
=== NAME  TestIntegrationSuite
    integration_test.go:4643:
                Error Trace:    /Users/dan/src/temporalio/sdk-go/test/integration_test.go:4643
                Error:          Received unexpected error:
                                Unable to perform workflow execution update due unexpected workflow task failure.
                Test:           TestIntegrationSuite
2025/02/19 17:35:55 INFO  Task processing failed with error Namespace integration-test-namespace TaskQueue tq-b66e3a7c-165c-4715-86ed-7cade72dc90b-TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound WorkerID [email protected]@ WorkerType WorkflowWorker Error BadUpdateWorkflowExecutionMessage: invalid state transition attempted for Update 6463ab6e-667f-44d0-a62b-28f7edb32ef0: received *update.Acceptance message while in state Completed
2025/02/19 17:35:55 INFO  Stopped Worker Namespace integration-test-namespace TaskQueue tq-b66e3a7c-165c-4715-86ed-7cade72dc90b-TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound WorkerID [email protected]@
=== NAME  TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound
    testing.go:1576: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
--- FAIL: TestIntegrationSuite (1.47s)
    --- FAIL: TestIntegrationSuite/TestNonDeterminismFailureCauseCommandNotFound (0.14s)
FAIL
FAIL    go.temporal.io/sdk/test 1.609s
testing: warning: no tests to run
PASS
ok      go.temporal.io/sdk/test/replaytests     1.081s [no tests to run]
FAIL
2025/02/19 17:35:57 integration test failed: exit status 1
exit status 1

spans.json

BadUpdateWorkflowExecutionMessage: invalid state transition attempted for Update 7c6747c5-38fd-4a00-9b64-27413049c11d: received *update.Acceptance message while in state Completed
@dandavison dandavison changed the title Improve NDE message Invalid update state transition Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant