Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-deterministic workflow code can send incorrect WFT completion without task failure #1838

Open
dandavison opened this issue Feb 20, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@dandavison
Copy link
Contributor

#1835 repros a situation in which non-deterministic workflow code sends an incorrect WFT completion without task failure, causing a invalid update state transition in History service.

The test causes a workflow to execute two WFTs. On WFT 2, it changes a boolean flag in the workflow making the code non-deterministic.

WFT1 is triggered by an update-with-start (update ID A) and is responded to by accepting & completing that update.

WFT2 is triggered by an update (update ID B).

However, when responding to WFT2, the SDK re-sends acceptance and completion messages for update A, which is incorrect.

@dandavison dandavison added the bug Something isn't working label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant