Skip to content

fix formatting of ValueError if horizon_elevation is less than 0 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
telegraphic merged 1 commit into from
Feb 20, 2025
Merged

fix formatting of ValueError if horizon_elevation is less than 0 #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pygdsm/base_observer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def generate(self, freq=None, obstime=None, horizon_elevation=None):

# Checking this separately encase someone tries to be smart and sets both the attribute and kwarg
if self._horizon_elevation < 0:
raise ValueError(f"Horizon elevation must be greater or equal to 0 degrees ({np.rad2deg(horizon_elevation)=}).")
raise ValueError(f"Horizon elevation must be greater or equal to 0 degrees (currently {np.rad2deg(horizon_elevation)}).")

# Match pyephem convertion -- string is degrees, int/float is rad
horizon_elevation = ephem.degrees(horizon_elevation or 0.0)
Expand All @@ -102,7 +102,7 @@ def generate(self, freq=None, obstime=None, horizon_elevation=None):

# Checking this separately encase someone tries to be smart and sets both the attribute and kwarg
if self._horizon_elevation < 0:
raise ValueError(f"Horizon elevation must be greater or equal to 0 degrees ({np.rad2deg(horizon_elevation)=}).")
raise ValueError(f"Horizon elevation must be greater or equal to 0 degrees (currently {np.rad2deg(horizon_elevation)}).")

# Rotation is quite slow, only recompute if time or frequency has changed, or it has never been run
if time_has_changed or self.observed_sky is None or horizon_has_changed:
Expand Down
Loading