fix formatting of ValueError if horizon_elevation is less than 0 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny bugfix - the error emitted ifhorizon_elevation < 0(added in #25) was not formatted correctly. Weirdly, this seems not to cause any issues on Python >= 3.8 (other than presumably raising a different error instead of raising the ValueError), but it seems Python <= 3.7 complains already at compile time, which breaks the module.Okay, I was not familiar with this - apparently this is annotated string formatting, which was added only with Python 3.8. So this is actually just another compatibility fix for outdated Python versions : )