-
Notifications
You must be signed in to change notification settings - Fork 1
Fix cpp11 rchk #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix cpp11 rchk #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything can be found in r-lib/cpp11#456.
For the time being, I vendored {cpp11} headers and patched them. Specifically:
Fix for
insert()inprotect.hpp.The key changes were to remove PROTECT/UNPROTECT calls since:
listfromget()is already preserved;xis protected by the caller.Fixes in
r_vector.hppKey changes to
reserve_data()safewrapper in bothresize_dataandresize_names()Key change to
resize_data()safewrapper aroundRf_allocVectoralready handles protection.Key changes to
resize_names()safewrapper aroundRf_allocVectoralready handles protection