Conversation
npry
force-pushed
the
npry/ci.windows
branch
30 times, most recently
from
9aac466 to
3345167
Compare
npry
force-pushed
the
npry/ci.windows
branch
9 times, most recently
from
0fcafa5 to
b43fb17
Compare
npry
commented
Apr 29, 2026
This was referenced Apr 29, 2026
danderson
approved these changes
Apr 29, 2026
Since `Instant` is a monotonic counter, it's not generally safe to add
and subtract `Duration`s from it without controlling for under/overflow.
While overflow may be relatively safely assumed not to occur, that's not
the case for underflow: in the `ts_tunnel` tests, a `TimeRange` was
constructed with an 1000s window around `Instant::now()`, but the
testing VMs are ephemeral and so hadn't been alive for 1k seconds, which
induced a panic. This clamps the range to the provided `Instant` on
overflow in `ts_time::TimeRange::new_around`.
Unfortunately there's no `saturating_{sub,add}` for
`std::time::Instant`, which I would've preferred here.
Signed-off-by: Nathan Perry <nathan@tailscale.com>
Change-Id: I614ccd1ec53f91f731f34d63d242b3906a6a6964
Doesn't make sense to install this by default anymore. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Ie552891d4598b0a0e110443e6ed939926a6a6964
Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I6cb998776295caa85f3e80fc7ce687846a6a6964
Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Icde2069d2d79f712581889e70078f0676a6a6964
Rather than specifying the toolchain everywhere via `+$TOOLCHAIN`, use `rustup override set` in the composite action. Configure common items in the rust ci action via env vars. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I98fcdb1e9f3b358c958d0a5f23af91a76a6a6964
Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I4b10b5e80f8562ead1bf039fd5c192be6a6a6964
It doesn't seem to work here, just don't depend on it or use it on this platform. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Ia64e4899b2373672e3c2768742453e836a6a6964
Updates #65 Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I5381bc94a5817a69cd848df929b5860c6a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run rust ci against
x86_64-pc-windows-{msvc,gnu}.Some associated bugfixes (review commit-by-commit), and also cleaned up the rust build with
rustup overridein the composite action and cargo env vars.ts_cli_utilandts_pythondon't run tests successfully on*-windows-gnu— I believets_pythonis because it gets confused about the fact that the rust lib name is alsotailscaleand for whatever reason that name collision just isn't handled properly on this platform, wherets_cli_utilseems to have a linking issue when thetracyfeature flag is on (which it is by default). I strip them out of the--workspace --all-featurestests with--excludeand then runts_cli_utilin a separate test phase with default features — not that it has any tests, but a) it could add them in the future, and we should run those b) the step is also a placeholder for any other crates that may need special-casing like this in the futureUpdates #65 -- not closing because I want to look at the other langs as well