Skip to content

[8.5] Add polyfill for DelayedTargetValidation #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

[8.5] Add polyfill for DelayedTargetValidation #541

merged 1 commit into from
Aug 20, 2025
+108 −0

Conversation

DanielEScherzer
Copy link
Contributor

No description provided.

@DanielEScherzer DanielEScherzer force-pushed the DelayedTargetValidation branch from e567ad4 to 4fb42c7 Compare August 20, 2025 10:08
stof
stof reviewed Aug 20, 2025
View reviewed changes
@DanielEScherzer DanielEScherzer force-pushed the DelayedTargetValidation branch from 4fb42c7 to 8d53116 Compare August 20, 2025 10:10
@DanielEScherzer
Copy link
Contributor Author

DanielEScherzer commented Aug 20, 2025 •
edited
Loading

Failures seem unrelated, I'll go debug the segfault from the 8.5 tests
Update: as far as I can tell seems to just be memory exhaustion, can I request that the job be re-run with debug logs enabled?

@DanielEScherzer DanielEScherzer force-pushed the DelayedTargetValidation branch from 8d53116 to c1a4ebc Compare August 20, 2025 10:29
nicolas-grekas
nicolas-grekas reviewed Aug 20, 2025
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Aug 20, 2025
View reviewed changes
@DanielEScherzer DanielEScherzer force-pushed the DelayedTargetValidation branch from 874ee3e to c1a4ebc Compare August 20, 2025 10:44
DanielEScherzer added a commit to DanielEScherzer/polyfill that referenced this pull request Aug 20, 2025
@DanielEScherzer
[8.4][ReflectionConstant] Update authorship comment
6ddfd41 
Per discussion on symfony#541
@DanielEScherzer DanielEScherzer mentioned this pull request Aug 20, 2025
Merged
nicolas-grekas added a commit that referenced this pull request Aug 20, 2025
@nicolas-grekas
minor #542 [8.4][ReflectionConstant] Update authorship comment (Danie…
22d170f 
…lEScherzer)

This PR was merged into the 1.x branch.

Discussion
----------

[8.4][ReflectionConstant] Update authorship comment

Per discussion on #541

Commits
-------

6ddfd41 [8.4][ReflectionConstant] Update authorship comment
@DanielEScherzer DanielEScherzer force-pushed the DelayedTargetValidation branch from c1a4ebc to 17524a5 Compare August 20, 2025 10:49
@nicolas-grekas
Copy link
Member

Thank you @DanielEScherzer.

@nicolas-grekas nicolas-grekas merged commit d154369 into symfony:1.x Aug 20, 2025
2 of 10 checks passed
@DanielEScherzer DanielEScherzer deleted the DelayedTargetValidation branch August 20, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielEScherzer @nicolas-grekas @stof