feature #541 [8.5] Add polyfill for DelayedTargetValidation (DanielEScherzer)

This PR was merged into the 1.x branch.

Discussion
----------

[8.5] Add polyfill for DelayedTargetValidation

Commits
-------

17524a5 [8.5] Add polyfill for DelayedTargetValidation

Author: nicolas-grekas

README.md

@@ -78,6 +78,7 @@ Polyfills are provided for:
 - the `get_error_handler` and `get_exception_handler` functions introduced in PHP 8.5;
 - the `NoDiscard` attribute introduced in PHP 8.5;
 - the `array_first` and `array_last` functions introduced in PHP 8.5;
+- the `DelayedTargetValidation` attribute introduced in PHP 8.5;
 
 It is strongly recommended to upgrade your PHP version and/or install the missing
 extensions whenever possible. This polyfill should be used only when there is no

src/Php85/README.md

@@ -6,6 +6,7 @@ This component provides features added to PHP 8.5 core:
 - [`get_error_handler` and `get_exception_handler`](https://wiki.php.net/rfc/get-error-exception-handler)
 - [`NoDiscard`](https://wiki.php.net/rfc/marking_return_value_as_important)
 - [`array_first` and `array_last`](https://wiki.php.net/rfc/array_first_last)
+- [`DelayedTargetValidation`](https://wiki.php.net/rfc/delayedtargetvalidation_attribute)
 
 More information can be found in the
 [main Polyfill README](https://github.com/symfony/polyfill/blob/main/README.md).

src/Php85/Resources/stubs/DelayedTargetValidation.php

@@ -0,0 +1,18 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+if (\PHP_VERSION_ID < 80500) {
+    // @author Daniel Scherzer <[email protected]>
+    #[Attribute(Attribute::TARGET_ALL)]
+    final class DelayedTargetValidation
+    {
+    }
+}

tests/Php85/DelayedTargetValidationTest.php

@@ -0,0 +1,88 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Polyfill\Tests\Php85;
+
+use Attribute;
+use DelayedTargetValidation;
+use PHPUnit\Framework\TestCase;
+use ReflectionClass;
+use ReflectionClassConstant;
+use ReflectionFunction;
+use ReflectionMethod;
+use ReflectionParameter;
+use ReflectionProperty;
+
+#[DelayedTargetValidation]
+class HasAttribute {
+	#[DelayedTargetValidation]
+	private $prop;
+
+	#[DelayedTargetValidation]
+	public const FOO = 'BAR';
+
+	#[DelayedTargetValidation]
+	public function __construct(
+		#[DelayedTargetValidation] $param
+	) {}
+}
+
+#[DelayedTargetValidation]
+function globalFunc() {}
+
+/**
+ * @author Daniel Scherzer <[email protected]>
+ * @requires PHP >= 8.0
+ */
+class DelayedTargetValidationTest extends TestCase
+{
+    public function testAttributeAttribute()
+    {
+		$ref = new ReflectionClass(\DelayedTargetValidation::class);
+		$attributes = $ref->getAttributes();
+		$this->assertCount(1, $attributes);
+		$attribute = $attributes[0];
+		$this->assertSame('Attribute', $attribute->getName());
+		$args = $attribute->getArguments();
+		$this->assertCount(1, $args);
+		$this->assertSame(Attribute::TARGET_ALL, $args[0]);
+        $this->expectException(\ReflectionException::class);
+        $this->expectExceptionMessage('Constant "missing" does not exist');
+        new \ReflectionConstant('missing');
+    }
+
+	/**
+	 * @dataProvider provideReflectionInstances
+	 */
+	public function testTargetValidation($reflectionSource)
+	{
+		$attributes = $reflectionSource->getAttributes();
+		$this->assertCount(1, $attributes);
+		$attrib = $attributes[0];
+		$this->assertSame('DelayedTargetValidation', $attrib->getName());
+		$this->assertSame([], $attrib->getArguments());
+		$this->assertInstanceOf(
+			DelayedTargetValidation::class,
+			$attrib->newInstance()
+		);
+	}
+
+	public static function provideReflectionInstances() {
+		yield 'Class' => [ new ReflectionClass(HasAttribute::class) ];
+		yield 'Property' => [ new ReflectionProperty(HasAttribute::class, 'prop')];
+		yield 'Class constant' => [ new ReflectionClassConstant(HasAttribute::class, 'FOO')];
+		yield 'Method' => [ new ReflectionMethod(HasAttribute::class, '__construct')];
+		yield 'Parameter' => [
+			new ReflectionParameter([HasAttribute::class, '__construct'], 'param')
+		];
+		yield 'Function' => [ new ReflectionFunction(__NAMESPACE__ . '\\globalFunc') ];
+	}
+}