ci(release): stage the release PR instead of opening it, and move to comlink 4.4.2 - #125
Merged
Merged
Conversation
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things: move the integration services to Comlink 4.4.2, and stop
prepare-releasefrom opening the release PR itself.Comlink 4.4.2
4.4.2 fixes the
/datafetch that neither 4.4.0 nor 4.4.1 could complete, so the two/datatests are no longer quarantined — thexfailmarkers and their now-unusedSwgohComlinkExceptionimports are gone, and the tests assert normally again.Both services move to
4.4.2. Thecomlink-hmacservice had been left on4.4.1; running the two on different builds means the HMAC tests exercise a different server than the rest of the suite, so the pin comment now says to keep them in step.prepare-release no longer opens the PR
gh pr createis removed. The workflow now:.github/release-pr/<tag>.md, including the new version's changelog section extracted from the regeneratedCHANGELOG.md;CHANGELOG.mdand pushesrelease/<tag>;main, headrelease/<tag>, title prefilled), plus the body text inline for copy-paste.permissionsdrops tocontents: write, and theGH_TOKENenv goes away — nothing calls the API any more.Why this is better than a bot-opened PR
A PR opened by
github-actions[bot]using the defaultGITHUB_TOKENdoes not triggerpull_requestworkflows. CI, Integration Tests, and Commit Lint all gate onpull_requestagainstmain, so the release PR would have arrived with no checks at all. Having a maintainer open it means the full suite runs beforemainmoves.The body-file tradeoff
The file lives on the release branch, so merging the release PR carries
.github/release-pr/<tag>.mdintomain— over time that accumulates one small markdown file per release. That is a deliberate choice: it makes the PR text a durable, reviewable artifact rather than something that exists only in a job summary that ages out.If you would rather
mainstay clean, two alternatives need only a small edit: upload the body as a workflow artifact instead of committing it, or keep the job summary alone. Both drop the permanent record.🤖 Generated with Claude Code