ci(release): trigger the back-merge on workflow_run so it actually fires - #128
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The back-merge workflow has never executed. Not once —
gh run list --workflow=backmerge.ymlis empty across both v2.2.0 and v2.3.0, which is why both back-merges were done by hand.Cause
release.yml creates the GitHub Release with
gh release createunder the defaultGITHUB_TOKEN. GitHub deliberately suppresses workflow triggers for events raised by that token, to prevent workflows recursively triggering themselves. Soon: release: types: [published]can never fire for a release this repository creates.This is the same class of problem as a bot-authored PR not running
pull_requestchecks — the constraint that shaped #125 and #126.Worth being explicit: #126 rewrote this workflow's body, and that work was correct but inert, because the workflow it improved was never being invoked.
Fix
workflow_runis not subject to the same suppression, so it fires when the release workflow finishes. The workflow name is matched againstrelease.yml's ownname:— verified in CI rather than eyeballed.workflow_runfires on completion regardless of outcome, so the job is guarded:A failed release no longer stages a back-merge.
workflow_dispatchis added as a manual escape hatch — it makes the workflow testable without cutting a release, and lets a maintainer stage a back-merge whenevermainanddevelopdrift.One deployment caveat
workflow_runonly fires for workflow files present on the default branch.maincurrently carries the oldrelease:-triggered version, so this fix does not take effect until it reachesmainvia the next release promotion. The v2.4.0 back-merge is the first one that can fire automatically; until then,workflow_dispatchis available the moment this merges.🤖 Generated with Claude Code