fix: update pgbouncer.get_auth (INFRA-1530) #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
force-pushed
the
km/update-pgbouncer-get-auth
branch
from
03f2d7d to
a4be80b
Compare
kangmingtay
changed the title
steve-chavez
requested changes
Apr 17, 2025
There was a problem hiding this comment.
@samrose @kangmingtay We need pgbouncer tests to ensure a regression doesn't happen.
They should be similar to the ones auth.out has. Namely:
- tests that cover the pgbouncer schema: tables with owners, functions with owners
- tests that cover the privileges roles have on the pgbouncer db objects
Just noted there's a test for the get_auth function:
postgres/nix/tests/expected/security.out
Line 14 in 61ff753
But it doesn't cover the owner, that needs to be added.
|
How urgent is this? I might be able to help with the tests here if there's time. |
kangmingtay
force-pushed
the
km/update-pgbouncer-get-auth
branch
from
f85a38e to
25d23b7
Compare
steve-chavez
approved these changes
Apr 22, 2025
steve-chavez
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
pgbouncer.get_authdefinitionWhat is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.