Skip to content

feat: keep pgjwt present but deactivated for orioledb only to avoid r… #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2025

Conversation

samrose
Copy link
Collaborator

@samrose samrose commented Apr 18, 2025

This PR will also need to address this change in https://github.com/supabase/infrastructure/blob/develop/init-scripts/project/00-initial-schema.sql#L20 as well.

At this time, the scope of this change is to fix the following issues only. If we need to expand the scope, it needs to be in a different PR.

  1. Remove pgjwt from the dbExtensions17 filter in flake.nix to ensure it's not included in PostgreSQL 17 builds
  2. Keep pgjwt in orioleFilteredExtensions so it's included in the orioledb-17 package
  3. Keep pgjwt in the supautils.privileged_extensions list in supautils.conf.j2 since it's a privileged extension
  4. Ensure pgjwt is not in the shared_preload_libraries list in postgresql.conf.j2 to prevent it from being loaded by default
  5. Keep the existing sed commands in Dockerfile-orioledb-17 and ansible/tasks/stage2-setup-postgres.yml that remove pgjwt from supautils.conf

This setup will:

  • Include pgjwt in the orioledb-17 package
  • Make it available as a privileged extension
  • Not load it by default in the AMI or local testing in orioledb-17
  • Retain it's deprecation in pg 17.4
  • still enabled in pg 15.x

So the only change needed was to allow pgjwt to be built and delivered with oriole-17 package + adjusmtment of init and test sql.

@samrose samrose requested review from a team as code owners April 18, 2025 15:28
@samrose samrose requested a review from soedirgo April 18, 2025 15:29
@samrose samrose requested a review from a team as a code owner April 18, 2025 16:44
@samrose samrose marked this pull request as draft April 18, 2025 16:57
@samrose samrose marked this pull request as ready for review April 19, 2025 19:04
@samrose
Copy link
Collaborator Author

samrose commented Apr 21, 2025

...testing in progress

@samrose samrose force-pushed the sam/pgjwt-oriole-deactivated branch from 3c62fb4 to d3d34df Compare April 22, 2025 17:11
@samrose
Copy link
Collaborator Author

samrose commented Apr 23, 2025

Pause/restore test from 17.0.1.053-orioledb to this version 17.0.1.067-orioledb-pgjwt-2 worked

image

@samrose samrose merged commit 8d32169 into develop Apr 23, 2025
13 of 14 checks passed
@samrose samrose deleted the sam/pgjwt-oriole-deactivated branch April 23, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants