Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AsynSubscriptions to publish async auth changes #591

Conversation

LuisLechugaRuiz
Copy link

What kind of change does this PR introduce?

Check issue: supabase/supabase-py#919

What is the current behavior?

Auth events are notified synchronously causing a crash on AsyncClient.

What is the new behavior?

Auth events now call async callback.

Copy link
Contributor

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be solved at the realtime client level and not in the function that you have changed here. The auth library shouldn't need this change for the realtime client to work as expected.

@silentworks
Copy link
Contributor

We've made a change to fix this in another PR and will release a new version soon. supabase/supabase-py#930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants