Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Await for realtime set auth on auth event #920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Await for realtime set auth on auth event #920

wants to merge 1 commit into from

Conversation

LuisLechugaRuiz
Copy link

What kind of change does this PR introduce?

Solves #919.

Needs: supabase/auth-py#591

What is the current behavior?

AsyncClient crashes due to missing await at self.realtime.set_auth()

What is the new behavior?

AsyncClient now awaits for self.realtime.set_auth

@LuisLechugaRuiz LuisLechugaRuiz mentioned this pull request Sep 3, 2024
Open
silentworks
silentworks requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be solved at the realtime client level and not in the function that you have changed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silentworks silentworks silentworks requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuisLechugaRuiz @silentworks