Skip to content

Add CiscoSyntax BadWifi package (Alt to existing) #9264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mburknoe wants to merge 1 commit into from
Closed

Add CiscoSyntax BadWifi package (Alt to existing) #9264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions repository/c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,6 +1204,16 @@
}
]
},
{
"name": "CiscoSyntax BadWifi",
"details": "https://github.com/badwifi/CiscoSyntax-Badwifi-Sublime-syntax",
Copy link
Collaborator

@braver braver Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your repo does not seem to exist at that URL (looks like this might be the one: https://github.com/mburknoe/CiscoSyntax-Badwifi-Sublime-syntax).

Copy link
Author

@mburknoe mburknoe Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you have the right one, Not sure how I made that mistake. I appreciate you fixing it.

Did you think that the proposed name is appropriate or should I name it something else?

Copy link
Collaborator

@braver braver Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can actually just replace the existing package and use its name.

Copy link
Author

@mburknoe mburknoe Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that alot, would you let me to try the pull request again, or do you have it covered?

If we replace the existing one using the same name, what does that do to all of the users that already have the existing one installed?

Copy link
Collaborator

@braver braver Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a PR and let you double check, that'll be quicker.

Your package will have a higher version than the existing one, so all users will be upgraded to your new version.

Ideally, you have a message explaining what happened and linking back to the original package (so that users who want that can still find it and manually install).

"releases": [
{
"sublime_text": ">=3000",
"tags": true
}
]
},
{
"name": "CiteBibtex",
"details": "https://github.com/sjpfenninger/citebibtex",
Expand Down
Loading