-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add CiscoSyntax BadWifi package (Alt to existing) #9264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| }, | ||
| { | ||
| "name": "CiscoSyntax BadWifi", | ||
| "details": "https://github.com/badwifi/CiscoSyntax-Badwifi-Sublime-syntax", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your repo does not seem to exist at that URL (looks like this might be the one: https://github.com/mburknoe/CiscoSyntax-Badwifi-Sublime-syntax).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you have the right one, Not sure how I made that mistake. I appreciate you fixing it.
Did you think that the proposed name is appropriate or should I name it something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can actually just replace the existing package and use its name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that alot, would you let me to try the pull request again, or do you have it covered?
If we replace the existing one using the same name, what does that do to all of the users that already have the existing one installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make a PR and let you double check, that'll be quicker.
Your package will have a higher version than the existing one, so all users will be upgraded to your new version.
Ideally, you have a message explaining what happened and linking back to the original package (so that users who want that can still find it and manually install).
|
If that is indeed the correct URL, we could replace the existing entry with yours. If that's ok with @tunnelsup, that would give everyone 1 up to date syntax package for this use case. |
|
Doesn't matter to me. I have no knowledge how popular or used my syntax highlighter is used and it's not maintained anymore. |
|
@tunnelsup thanks! We'll continue in #9267 |
My package is an alternative to the existing "Cisco Syntax Highlighter". The existing one has not been updated in 7 years, and really doesn't do anything so I have never used it as a CCIE Cisco Engineer and over my career been frustrated by the lack of Cisco Syntax in Sublime
Mine will be active and I'll address recomendations from users.