Skip to content

Add subtotal as SUBTOTAL DisplayItem in Google Pay #13403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cttsai-stripe wants to merge 3 commits into from
+26 −0
Closed

Add subtotal as SUBTOTAL DisplayItem in Google Pay #13403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cd9959
Update GPay display items tests to expect SUBTOTAL item
cttsai-stripe Jul 10, 2026
cca9ee4
Add subtotal as SUBTOTAL DisplayItem in Google Pay payment request
cttsai-stripe Jul 10, 2026
e69f5f2
Remove redundant no-discount-or-tax subtotal test
cttsai-stripe Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .../java/com/stripe/android/paymentelement/confirmation/gpay/GooglePayDisplayItemsFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,22 @@ internal object GooglePayDisplayItemsFactory {
items += checkoutSession.lineItems.map { it.asDisplayItem() }

checkoutSession.totalSummary?.let { summary ->
items += summary.asSubtotalDisplayItem()
items += summary.discountAmounts.map { it.asDisplayItem() }
items += summary.taxAmounts.map { it.asDisplayItem() }
}

return items
}

private fun CheckoutSession.TotalSummary.asSubtotalDisplayItem(): GooglePayJsonFactory.DisplayItem {
return GooglePayJsonFactory.DisplayItem(
label = SUBTOTAL_LABEL,
type = GooglePayJsonFactory.DisplayItem.Type.SUBTOTAL,
price = subtotal,
)
}

private fun CheckoutSession.LineItem.asDisplayItem(): GooglePayJsonFactory.DisplayItem {
val label = if (quantity > 1) "$name x$quantity" else name
return GooglePayJsonFactory.DisplayItem(
Expand All @@ -54,4 +63,6 @@ internal object GooglePayDisplayItemsFactory {
price = amount,
)
}

private const val SUBTOTAL_LABEL = "Subtotal"
}
15 changes: 15 additions & 0 deletions ...a/com/stripe/android/paymentelement/confirmation/gpay/GooglePayDisplayItemsFactoryTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ class GooglePayDisplayItemsFactoryTest {
type = GooglePayJsonFactory.DisplayItem.Type.LINE_ITEM,
price = 2000L,
),
displayItem(
label = "Subtotal",
type = GooglePayJsonFactory.DisplayItem.Type.SUBTOTAL,
price = 2000L,
),
displayItem(
label = "SAVE50",
type = GooglePayJsonFactory.DisplayItem.Type.DISCOUNT,
Expand Down Expand Up @@ -150,6 +155,11 @@ class GooglePayDisplayItemsFactoryTest {
type = GooglePayJsonFactory.DisplayItem.Type.LINE_ITEM,
price = 1000L,
),
displayItem(
label = "Subtotal",
type = GooglePayJsonFactory.DisplayItem.Type.SUBTOTAL,
price = 1000L,
),
displayItem(
label = "Sales Tax",
type = GooglePayJsonFactory.DisplayItem.Type.TAX,
Expand Down Expand Up @@ -182,6 +192,11 @@ class GooglePayDisplayItemsFactoryTest {
type = GooglePayJsonFactory.DisplayItem.Type.LINE_ITEM,
price = 2000L,
),
displayItem(
label = "Subtotal",
type = GooglePayJsonFactory.DisplayItem.Type.SUBTOTAL,
price = 2000L,
),
displayItem(
label = "SAVE50",
type = GooglePayJsonFactory.DisplayItem.Type.DISCOUNT,
Expand Down
Loading