Add subtotal as SUBTOTAL DisplayItem in Google Pay#13403
Draft
cttsai-stripe wants to merge 3 commits into
Draft
Conversation
Committed-By-Agent: claude
Committed-By-Agent: claude
cttsai-stripe
changed the title
Committed-By-Agent: claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
total.subtotalfrom CheckoutSession as aSUBTOTALDisplayItem row in the Google Pay payment request.The subtotal (pre-discount, pre-tax sum of line items) was already available on
TotalSummarybut not being surfaced to the Google Pay sheet. This wires it in via the existingGooglePayDisplayItemsFactory, positioned after line items and before discounts/taxes — matching receipt conventions.Motivation
MOBILESDK-4641. The Google Pay payment sheet shows a line-item breakdown; showing the subtotal helps customers understand the price adjustments (discounts, taxes) that follow it.
Testing
Updated 3 existing tests in
GooglePayDisplayItemsFactoryTestto assert SUBTOTAL appears in the correct position. Added 1 new test for the case wheretotalSummaryhas no discounts or taxes.Screenshots
N/A — DisplayItems are rendered by the Google Pay SDK sheet, not by Stripe UI.
Changelog