make mining_device into submodule of integration_tests_sv2 crate

[plebhash]

this is one potential (and opinionated) approach to close #354

one alternative is to start publishing mining_device to crates.io

[Shourya742]

Concept ACK.

[xyephy]

cargo publish --dry-run still fails after this change:

error: all dependencies must have a version specified when publishing.
dependency `key-utils` does not specify a version

These git deps need version specifiers:

key-utils = { version = "1.2.0", git = "https://github.com/stratum-mining/stratum", rev = "v1.5.0" }
stratum-common = { version = "4.0.1", git = "https://github.com/stratum-mining/stratum", rev = "v1.5.0", features = ["with_network_helpers"] }

Both versions match the v1.5.0 tag and exist on crates.io.

[GitGab19]

After @xyephy's suggestions are tackled, this PR is good to go.

[GitGab19]

Why can't we get these two from the (already imported) stratum-apps crate?

[plebhash]

yeah, this aligns with @xyephy comment above

I was able to remove key-utils and use stratum-apps for that piece

unfortunately though, stratum-common is the part that is still not covered by stratum-apps today.... the newly embedded mining_device module still relies on stratum_common::network_helpers_sv2::noise_connection::Connection plus a fair amount of stratum_common::roles_logic_sv2::{...} surface, and stratum-apps does not currently re-export that.

I think the paths ahead are:

1. keep stratum-common as an explicit dependency for now (current state of this PR);
2. extend stratum-apps to re-export stratum-common / the relevant facade, which would let us avoid declaring it explicitly here;
3. refactor the migrated mining_device module so it no longer depends on stratum-common at all.

this PR is currently following 1 because it is the lowest hanging fruit, but happy to pivot towards 2 or 3 (although scope is a bit bigger)

[plebhash]

wait, just found some compilation errors

maybe the analysis above is incomplete

[plebhash]

ok ended up pivoting

keeping stratum-common as an explicit dep was not enough, because it still pulled the older published stack and cargo publish --dry-run failed while verifying it (framing_sv2 v5.0.1).

so I went with the stronger version of your suggestion:

• key-utils now comes from stratum-apps
• mining_device was refactored to stop depending on stratum-common entirely
• it now uses the stratum-apps / stratum_core stack directly

with that change, cargo publish --dry-run passes

[plebhash]

cargo publish --dry-run still fails after this change:

error: all dependencies must have a version specified when publishing.
dependency `key-utils` does not specify a version

These git deps need version specifiers:

key-utils = { version = "1.2.0", git = "https://github.com/stratum-mining/stratum", rev = "v1.5.0" }
stratum-common = { version = "4.0.1", git = "https://github.com/stratum-mining/stratum", rev = "v1.5.0", features = ["with_network_helpers"] }

Both versions match the v1.5.0 tag and exist on crates.io.

thanks, should be addressed