Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds two independent, icon-only controls to the right rail: one alternates single-page and two-page layouts, and one toggles continuous scrolling. Each shows the current mode using the same neutral styling as the fit-page/fit-width button. A separate gear keeps the existing Page display menu reachable.
Both controls dispatch the existing commands, preserve the other display setting, and leave document bytes and dirty state unchanged. The two scrolling SVGs are original, theme-tinted artwork with per-file attribution under the project licence.
How you verified it
Repeated layout changes with continuous scrolling both on and off, and repeated scrolling changes in both page layouts, through focused control-channel regressions.
Confirmed the new layout regression fails against the old two-button implementation before applying the toggle.
Native Windows checks in Spanish: both icon states, repeated clicks, and the gear menu, using a synthetic blank PDF.
cargo fmt --checkScoped Clippy for the UI and desktop app, all targets, with
-D warnings.Five focused rail control regressions and six page-display regressions passed.
Asset audit and dependency-layer gate passed.
Full workspace and wasm checks are left to CI.
Never-crash and security
No new input parsing, indexing, panics, unsafe code, network access, or document writes. Existing view commands and the opt-in control channel remain the execution paths.
Provenance and parity
The added SVGs are contributor-original vectors; no proprietary assets, fonts, or copied third-party code are included. Attribution, the layout/continuous parity evidence, and the M3 roadmap notes are updated.
Reviewer notes
The layout icon indicates the current layout; its tooltip names the layout that clicking will select. Selected backgrounds and visible captions are deliberately omitted to match the fit toggle. The gear menu retains all existing scrolling, cover-page and zoom options.