-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go: upgrade to 1.24 #746
Merged
Merged
go: upgrade to 1.24 #746
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
28504ff
go: upgrade to 1.24
adambabik 65cb10d
Bump Go version in Dockerfile
adambabik 1cf0015
Fix all Go versions in ci.yml
adambabik bc875b3
Test go tool -n checklocks output
adambabik cb64b4b
runnerv2service: drain readSendDone channel
adambabik 0edd571
Move checklocks back to go env GOPATH
adambabik bea4659
Run go mod tidy
adambabik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,10 +76,6 @@ test-docker/run: | |
| -v dev.runme.test-env-gocache:/root/.cache/go-build \ | ||
| runme-test-env:latest | ||
|
|
||
| .PHONY: test/update-snapshots | ||
| test/update-snapshots: | ||
| @TZ=UTC UPDATE_SNAPSHOTS=true go test ./... | ||
|
|
||
| .PHONY: test/parser | ||
| test/parser: | ||
| ./runme --version | ||
|
|
@@ -93,10 +89,18 @@ test/coverage/html: | |
| test/coverage/func: | ||
| go tool cover -func=cover.out | ||
|
|
||
| .PHONY: install/dev | ||
| install/dev: | ||
| @# Most of the tools got moved to go.mod, but this is used in buf.gen.yaml. | ||
| @# Remove when buf starts respecting binaries from provided by "go tool". | ||
| go install github.com/stateful/go-proto-gql/protoc-gen-gql@latest | ||
| @# Does not work with "go tool". | ||
| go install gvisor.dev/gvisor/tools/checklocks/cmd/checklocks@go | ||
|
|
||
| .PHONY: fmt | ||
| fmt: | ||
| @gofumpt -w . | ||
| @goimports -local="github.com/stateful/runme" -w -l . | ||
| @go tool gofumpt -w . | ||
| @go tool goimports -local="github.com/stateful/runme" -w -l . | ||
|
|
||
| .PHONY: generate | ||
| generate: _generate fmt | ||
|
|
@@ -108,39 +112,23 @@ _generate: | |
| .PHONY: lint | ||
| lint: | ||
| @# "gofumpt -d ." does not return non-zero exit code if there are changes | ||
| @test -z $(shell gofumpt -d .) | ||
| test -z $(shell go tool gofumpt -d .) | ||
| @# "goimports -d ." does not return non-zero exit code if there are changes | ||
| @test -z $(shell goimports -local="github.com/stateful/runme" -l .) | ||
| @revive \ | ||
| test -z $(shell go tool goimports -local="github.com/stateful/runme" -l .) | ||
| go tool revive \ | ||
| -config revive.toml \ | ||
| -formatter friendly \ | ||
| -exclude integration/subject/... \ | ||
| ./... | ||
| @staticcheck ./... | ||
| @gosec -quiet -exclude=G110,G204,G304,G404 -exclude-generated ./... | ||
| @go vet -stdmethods=false ./... | ||
| @go vet -vettool=$(shell go env GOPATH)/bin/checklocks ./... | ||
| go tool staticcheck ./... | ||
| go tool gosec -quiet -exclude=G110,G115,G204,G304,G404 -exclude-generated ./... | ||
| go vet -stdmethods=false ./... | ||
| go vet -vettool=$(shell go env GOPATH)/bin/checklocks ./... | ||
|
|
||
| .PHONY: pre-commit | ||
| pre-commit: build wasm test lint | ||
| pre-commit run --all-files | ||
|
|
||
| .PHONY: install/dev | ||
| install/dev: | ||
| go install github.com/mgechev/[email protected] | ||
| go install github.com/securego/gosec/v2/cmd/[email protected] | ||
| go install honnef.co/go/tools/cmd/[email protected] | ||
| go install mvdan.cc/[email protected] | ||
| go install github.com/icholy/[email protected] | ||
| go install github.com/stateful/go-proto-gql/protoc-gen-gql@latest | ||
| go install github.com/atombender/[email protected] | ||
| go install gvisor.dev/gvisor/tools/checklocks/cmd/checklocks@go | ||
| go install golang.org/x/tools/cmd/goimports@latest | ||
|
|
||
| .PHONY: install/goreleaser | ||
| install/goreleaser: | ||
| go install github.com/goreleaser/[email protected] | ||
|
|
||
| .PHONY: proto/generate | ||
| proto/generate: proto/_generate fmt | ||
|
|
||
|
|
@@ -170,13 +158,23 @@ proto/dev/reset: | |
| proto/publish: | ||
| @cd ./pkg/api/proto && buf push | ||
|
|
||
| .PHONY: schema/generate | ||
| schema/generate: | ||
| go-jsonschema -t \ | ||
| .PHONY: config/schema/generate | ||
| config/schema/generate: | ||
| @go tool go-jsonschema -t \ | ||
| -p config \ | ||
| --tags "json,yaml" \ | ||
| -o internal/config/config_schema.go \ | ||
| internal/config/config.schema.json | ||
| internal/config/config.schema.json | ||
|
|
||
| .PHONY: gql/schema/generate | ||
| gql/schema/generate: | ||
| @go run ./cmd/gqltool/main.go > ./internal/client/graphql/schema/introspection_query_result.json | ||
| @npm install --prefix internal/client/graphql/schema | ||
| @cd ./internal/client/graphql/schema && npm run convert | ||
|
|
||
| .PHONY: install/goreleaser | ||
| install/goreleaser: | ||
| go install github.com/goreleaser/[email protected] | ||
|
|
||
| .PHONY: release | ||
| release: install/goreleaser | ||
|
|
@@ -186,9 +184,3 @@ release: install/goreleaser | |
| .PHONY: release/publish | ||
| release/publish: install/goreleaser | ||
| @goreleaser release | ||
|
|
||
| .PHONY: update-gql-schema | ||
| update-gql-schema: | ||
| @go run ./cmd/gqltool/main.go > ./internal/client/graphql/schema/introspection_query_result.json | ||
| @npm install --prefix internal/client/graphql/schema | ||
| @cd ./internal/client/graphql/schema && npm run convert | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| FROM golang:1.23-bookworm | ||
| FROM golang:1.24-bookworm | ||
|
|
||
| LABEL org.opencontainers.image.authors="StatefulHQ <[email protected]>" | ||
| LABEL org.opencontainers.image.source="https://github.com/stateful/runme" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted, because I could not find any reference to it.