go: upgrade to 1.24 #746
Merged
go: upgrade to 1.24 #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambabik
commented
Feb 18, 2025
| @@ -76,10 +76,6 @@ test-docker/run: | |||
| -v dev.runme.test-env-gocache:/root/.cache/go-build \ | |||
| runme-test-env:latest | |||
|
|
|||
| .PHONY: test/update-snapshots | |||
| test/update-snapshots: | |||
| @TZ=UTC UPDATE_SNAPSHOTS=true go test ./... | |||
There was a problem hiding this comment.
Deleted, because I could not find any reference to it.
adambabik
commented
Feb 18, 2025
| max := 9 - len(strings.Split(relFilename, string(filepath.Separator))) | ||
| if len(words) > max { | ||
| intro = strings.Join(words[:max], " ") + "..." | ||
| maxComponents := 9 - len(strings.Split(relFilename, string(filepath.Separator))) |
There was a problem hiding this comment.
Changed a variable name, because gosec complained that it was overwriting a global symbol. AFAIK from Go 1.23 there are max and min functions.
adambabik
commented
Feb 18, 2025
| @@ -184,6 +184,10 @@ func (e *execution) Wait(ctx context.Context, sender runnerv2.RunnerService_Exec | |||
| e.closeIO() | |||
|
|
|||
| if waitErr != nil { | |||
| // Drain the readSendDone channel to avoid goroutine leaks. | |||
There was a problem hiding this comment.
Found when running e2e tests thanks to the logger reporting calls after the test case finished.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #744