[Merged by Bors] - Initial attempt at making resource requests, limits and pvcs configurable #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nightkr
reviewed
May 20, 2022
…onsecutive without holes.
6 tasks
# Conflicts: # rust/operator-binary/src/controller.rs
…o the best practice in https://dzone.com/articles/best-practices-java-memory-arguments-for-container Relevant quote: If you are running *only your Java application* within the container, then set initial heap size (i.e., using either one of ‘-XX:InitialRAMFraction’, ‘-XX:InitialRAMPercentage’, -Xms) to the same size as max heap size. Setting initial heap size and max heap has certain advantages. One of them is: you will incur lower Garbage Collection pause times. Because whenever heap size grows from the initial allocated size, it will pause the JVM. It can be circumvented when you set initial and max heap sizes to be the same. Besides that, if you have an under-allocated container’s memory size, then JVM will not even start (which is better than experiencing OutOfMemoryError when transactions are in flight).
…ets into main first) and enabled CI for testing (same deal, also from #277).
razvan
reviewed
Jun 8, 2022
Addressed comment by Razvan Co-authored-by: Razvan-Daniel Mihai <[email protected]>
Reduced test parallelism to 1
Added tracing spans.
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 9, 2022
…able (#265) ## Description Fixes #252 This doesn't work with the currently released version of the operator-rs, and is only intended for code study, as this might serve as a template for making similar changes in other operators. Most notably it depends on stackabletech/operator-rs#368 and a PR to make small changes to the Resource structs to make them work with the Merging code, which can in turn only be created once the above mentioned PR has been merged. *Please add a description here. This will become the commit message of the merge request later.* Co-authored-by: Razvan-Daniel Mihai <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This was referenced Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #252
This doesn't work with the currently released version of the operator-rs, and is only intended for code study, as this might serve as a template for making similar changes in other operators.
Most notably it depends on stackabletech/operator-rs#368 and a PR to make small changes to the Resource structs to make them work with the Merging code, which can in turn only be created once the above mentioned PR has been merged.
Please add a description here. This will become the commit message of the merge request later.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information