[Merged by Bors] - Updated code to adhere to ADR018 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains a breaking change, since the version that is specified for NiFi now has to include a stackable image version.
razvan
approved these changes
May 19, 2022
…to run with the following versions: - zookeeper - 3.5.8-stackable0.7.0 - 3.6.3-stackable0.7.0 - 3.7.0-stackable0.7.0 - 3.8.0-stackable0.7.0 - nifi - 1.15.0-stackable0.4.0
|
I have added migration of the tests to this PR and adapted the tests. |
|
Just a reminder that there is also : https://github.com/stackabletech/integration-tests/pull/242 which didn't get copied over here because #265 isn't merged. |
|
I have included https://github.com/stackabletech/integration-tests/pull/242 into this PR. |
Which was stupid, because I should have rebased #265 and included them there, I will revert. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
## Description This contains a breaking change, since the version that is specified for NiFi now has to include a stackable image version. Previously the version could be specified as "version: 3.2.1" and the operator simply added the stackable version to this. But going forward we have decided that the image version has to be explictly specified, so it will now have to be "version: 3.2.1-stackable-0.1.0" or similar. This is in accordance with ADR18 (https://docs.stackable.tech/home/contributor/adr/ADR018-product_image_versioning.html). This PR also moves the integration tests back to this repository and parameterizes them to test with our currently supported ZooKeeper versions.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This contains a breaking change, since the version that is specified for NiFi now has to include a stackable image version.
Previously the version could be specified as "version: 3.2.1" and the operator simply added the stackable version to this. But going forward we have decided that the image version has to be explictly specified, so it will now have to be "version: 3.2.1-stackable-0.1.0" or similar.
This is in accordance with ADR18 (https://docs.stackable.tech/home/contributor/adr/ADR018-product_image_versioning.html).
This PR also moves the integration tests back to this repository and parameterizes them to test with our currently supported ZooKeeper versions.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information