Unified RowMapper infrastructure #2000
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Closed
mipo256
force-pushed
the
extend-visibility
branch
from
93d0b53 to
a8044cb
Compare
schauder
requested changes
Mar 13, 2025
.../src/main/java/org/springframework/data/jdbc/repository/support/JdbcQueryLookupStrategy.java
Outdated
Show resolved
Hide resolved
...data-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/RowMapperFactory.java
Show resolved
Hide resolved
...ata-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/AbstractJdbcQuery.java
Show resolved
Hide resolved
...data-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/RowMapperFactory.java
Outdated
Show resolved
Hide resolved
schauder
added
status: waiting-for-feedback
mipo256
force-pushed
the
extend-visibility
branch
2 times, most recently
from
e87abbb to
1d65e9c
Compare
|
@schauder What |
spring-projects-issues
added
status: feedback-provided
mipo256
force-pushed
the
extend-visibility
branch
from
1d65e9c to
0227022
Compare
mipo256
commented
Mar 16, 2025
.../src/main/java/org/springframework/data/jdbc/repository/support/JdbcQueryLookupStrategy.java
Show resolved
Hide resolved
.../src/main/java/org/springframework/data/jdbc/repository/support/JdbcQueryLookupStrategy.java
Show resolved
Hide resolved
...ata-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/AbstractJdbcQuery.java
Show resolved
Hide resolved
mipo256
force-pushed
the
extend-visibility
branch
from
0227022 to
4cb07a6
Compare
mipo256
force-pushed
the
extend-visibility
branch
from
4cb07a6 to
4bc2fd6
Compare
|
Could you please sign off on your commit for DCO. |
|
The PR is marked as draft. Is there anything you don't consider ready yet? |
|
@schauder The PR was inspired by the following issue in the YDB dialect on top of spring data jdbc. Most likely, we'll also need to allow for the extension of I'll convert it as ready very shortly, as soon as I'll understand that the dialect is capable to extend everything that it needs. Or, alternatively, we can merge this PR and other possible changes would happen in the upcoming PRs. What are your thoughts on this? |
|
Ok, I'll wait with further reviewing until we have something that is complete from your perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1998