Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty verison bump #2001

Closed
wants to merge 1 commit into from
Closed

Conversation

mipo256
Copy link
Contributor

@mipo256 mipo256 commented Feb 21, 2025

When working on #2000 PR, I realized that the build on main is failing due to incompatibility of R2DBC driver and netty:

java.lang.NoClassDefFoundError: io/netty/resolver/dns/DnsNameResolverChannelStrategy
	at reactor.netty.transport.NameResolverProvider$Build.<clinit>(NameResolverProvider.java:682)
	at reactor.netty.transport.NameResolverProvider.builder(NameResolverProvider.java:303)
	at reactor.netty.tcp.TcpResources.<clinit>(TcpResources.java:426)
	at org.mariadb.r2dbc.MariadbConnectionConfiguration.<init>(MariadbConnectionConfiguration.java:142)
	at org.mariadb.r2dbc.MariadbConnectionConfiguration.<init>(MariadbConnectionConfiguration.java:32)
	at org.mariadb.r2dbc.MariadbConnectionConfiguration$Builder.build(MariadbConnectionConfiguration.java:651)
	at org.springframework.data.r2dbc.dialect.DialectResolverUnitTests.shouldResolveDatabaseType(DialectResolverUnitTests.java:41)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.ClassNotFoundException: io.netty.resolver.dns.DnsNameResolverChannelStrategy
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)

I've bumped the patch netty version to include the missing class. The version that project-reactor 1.2.3 that we're btw are using requires netty 4.1.118.Final

CC: @mp911de @schauder

Signed-off-by: mipo256 <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 21, 2025
@mp911de mp911de self-assigned this Feb 24, 2025
@mipo256
Copy link
Contributor Author

mipo256 commented Feb 25, 2025

Hey @mp911de! This change seems to be very trivial, will you be able to take a look?

@mp911de mp911de added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 3, 2025
@mp911de
Copy link
Member

mp911de commented Mar 3, 2025

This was already done with dff24c6 (#1992). Can you check whether you have had the latest code pulled in?

@mp911de mp911de closed this Mar 3, 2025
@mp911de mp911de added the status: duplicate A duplicate of another issue label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants