Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add feature flag for multi block failure messages. #10061

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

armory-abedonik
Copy link
Contributor

No description provided.

@ovidiupopa07 ovidiupopa07 added the ready to merge Reviewed and ready for merge label Nov 16, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Nov 16, 2023
@mergify mergify bot merged commit 374f724 into spinnaker:master Nov 16, 2023
@ovidiupopa07
Copy link
Contributor

This would also be useful to have in older releases - to see better what is going wrong. By default, the enhancement is disabled and must be enabled using the MULTI_BLOCK_FAILURE_MESSAGES_ENABLED flag set to true.

@ovidiupopa07
Copy link
Contributor

ovidiupopa07 commented Nov 20, 2023

@Mergifyio backport release-1.28.x

Copy link
Contributor

mergify bot commented Nov 20, 2023

back -port release-1.28.x

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

Copy link
Contributor

mergify bot commented Nov 20, 2023

backport release-1.28.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 20, 2023
(cherry picked from commit 374f724)

# Conflicts:
#	packages/app/src/settings.js
#	packages/kubernetes/src/pipelines/stages/deployManifest/manifestStatus/DeployStatus.tsx
ovidiupopa07 pushed a commit that referenced this pull request Nov 22, 2023
(cherry picked from commit 374f724)

# Conflicts:
#	packages/app/src/settings.js
#	packages/kubernetes/src/pipelines/stages/deployManifest/manifestStatus/DeployStatus.tsx
mergify bot added a commit that referenced this pull request Nov 23, 2023
…0061) (#10062)

* feat: Add feature flag for multi block failure messages. (#10061)

(cherry picked from commit 374f724)

# Conflicts:
#	packages/app/src/settings.js
#	packages/kubernetes/src/pipelines/stages/deployManifest/manifestStatus/DeployStatus.tsx

* fix: Fix conflicts

---------

Co-authored-by: armory-abedonik <[email protected]>
Co-authored-by: Ovidiu Popa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.33
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants