Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split deployment failure messages. #10060

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

armory-abedonik
Copy link
Contributor

In the context of the deploy manifest stage, numerous failure messages are currently consolidated into a single message, rendering the information less user-friendly. This is primarily attributed to the necessity of scrolling through the lengthy message and attentively discerning where one exception concludes and another commences. The proposed resolution in this pull request involves segregating failure messages into distinct blocks. For a more comprehensive understanding of this enhancement, kindly refer to the attached video demonstration.

CDSH-499-demo.mov

Copy link
Contributor

@kkotula kkotula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ovidiupopa07 ovidiupopa07 added the ready to merge Reviewed and ready for merge label Nov 14, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Nov 14, 2023
@mergify mergify bot merged commit 73dda48 into spinnaker:master Nov 14, 2023
@armory-abedonik armory-abedonik deleted the CDSH-499 branch November 14, 2023 14:43
@ovidiupopa07
Copy link
Contributor

ovidiupopa07 commented Nov 20, 2023

Feature flag added in #10061.

@ovidiupopa07
Copy link
Contributor

@Mergifyio backport release-1.28.x

Copy link
Contributor

mergify bot commented Nov 20, 2023

backport release-1.28.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 20, 2023
mergify bot added a commit that referenced this pull request Nov 21, 2023
(cherry picked from commit 73dda48)

Co-authored-by: armory-abedonik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.33
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants