JP-3793: Fix numbers of flagged groups #338
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 86.14% 86.42% +0.27%
==========================================
Files 50 50
Lines 9313 9369 +56
==========================================
+ Hits 8023 8097 +74
+ Misses 1290 1272 -18 ☔ View full report in Codecov by Sentry. |
| @@ -22,6 +22,89 @@ def _cube(ngroups, nints=1, nrows=204, ncols=204, readnoise=10): | |||
|
|
|||
| return _cube | |||
|
|
|||
| def test_sigclip_not_enough_groups(setup_cube): | |||
There was a problem hiding this comment.
This test has three different definitions with the same name, so only the last one will be run. Testing locally, it looks like the first one fails and the second two pass, as written.
There was a problem hiding this comment.
Ah, I thought that was odd but wasn't sure whether same-named tests were ok or not. I've given them unique names now. Looks like that also fixes why I wasn't able to get any pytests against stcal to run locally.
@mwregan2 Any thoughts on why some of these new tests are failing?
| ) | ||
| assert total_crs != -99 | ||
|
|
||
| def test_nosigclip_with_enough_groups(setup_cube): |
There was a problem hiding this comment.
This test is also defined again later with the same name, so only the second one runs. Testing locally, it looks like both pass as written.
Resolves JP-3793 regarding inaccurate calculation of the number of groups in the jump step. This PR updates prior #317 to account for recent unrelated changes.