Remove external publishing workflow form the CI #1024
Merged
+1,184
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filip131311
changed the title
filip131311
force-pushed
the
@Filip131311/FixCI
branch
from
0d1527a to
6491908
Compare
kmagiera
approved these changes
Mar 10, 2025
kmagiera
reviewed
Mar 10, 2025
| pat: ${{ secrets.OPENVSX_MARKETPLACE_TOKEN }} | ||
| target: ${{ steps.set_targets.outputs.targets }} | ||
| working-directory: packages/vscode-extension | ||
| run: npm run openVSX:publish -- --pat ${{ secrets.VSCODE_MARKETPLACE_TOKEN }} --target ${{ steps.set_targets.outputs.targets }} |
There was a problem hiding this comment.
you should use OPENVSX_MARKETPLACE_TOKEN here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the approach to the publishing CI and removes the external
HaaLeo/publish-vscode-extension@v1replacing it with underlingvsceandosvxcommands. This is necessary because of a bug that was surfaced by this CI run.How Has This Been Tested:
The final version was not tested as it would mean running the CI