Skip to content

Commit

Permalink
Remove external publishing workflow form the CI (#1024)
Browse files Browse the repository at this point in the history
This PR changes the approach to the publishing CI and removes the
external `HaaLeo/publish-vscode-extension@v1` replacing it with
underling `vsce` and `osvx` commands. This is necessary because of a bug
that was surfaced by
[this](https://github.com/software-mansion/radon-ide/actions/runs/13769019110)
CI run.

### How Has This Been Tested: 

The final version was not tested as it would mean running the CI
  • Loading branch information
filip131311 authored Mar 10, 2025
1 parent db61279 commit 9f44897
Show file tree
Hide file tree
Showing 3 changed files with 1,184 additions and 83 deletions.
21 changes: 7 additions & 14 deletions .github/workflows/package-extension.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,20 +95,13 @@ jobs:
path: ${{ steps.package_extension.outputs.vsix_path }}

- name: Publish to Visual Studio Marketplace
uses: HaaLeo/publish-vscode-extension@v1
if: ${{ github.event.inputs.publish == 'true' }}
working-directory: packages/vscode-extension
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
registryUrl: https://marketplace.visualstudio.com
pat: ${{ secrets.VSCODE_MARKETPLACE_TOKEN }}
target: ${{ steps.set_targets.outputs.targets }}

GH_TOKEN: ${{ github.token }}
run: npm run vscode:publish -- --pat ${{ secrets.VSCODE_MARKETPLACE_TOKEN }} --target ${{ steps.set_targets.outputs.targets }}

- name: Publish to Open VSX Registry
uses: HaaLeo/publish-vscode-extension@v1
if: ${{ github.event.inputs.publish == 'true' }}
working-directory: packages/vscode-extension
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
pat: ${{ secrets.OPENVSX_MARKETPLACE_TOKEN }}
target: ${{ steps.set_targets.outputs.targets }}
GH_TOKEN: ${{ github.token }}
run: npm run openVSX:publish -- --pat ${{ secrets.OPENVSX_MARKETPLACE_TOKEN }} --target ${{ steps.set_targets.outputs.targets }}
Loading

0 comments on commit 9f44897

Please sign in to comment.