Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry Monitoring (and break API routes) #5

Merged
merged 6 commits into from
Apr 12, 2022

Conversation

james-wallis
Copy link
Collaborator

@james-wallis james-wallis commented Apr 12, 2022

Adds Sentry

  • Sentry didn't work without adding: useServerlessTraceTarget - same issue in the Launcher
  • As a result of either adding Sentry or useServerlessTraceTarget Next.js API routes now return a 503 and are broken
  • There are a few Sentry related issues open on serverless-nextjs. 503 error on invoking an API endpoint serverless-nextjs/serverless-next.js#1776 has a comment at the bottom showing that Sentry doesn't work with the serverless target
  • Given that we likely won't need to use API routes, I've opted to add Sentry but we can reevaluate in the future if our requirements change

From Sentry docs:

@sentry/nextjs does not support configurations with the serverless target. To use the SDK in serverless environments, switch to using the experimental-serverless-trace target, which is recommended by the Next.js maintainers for apps using Next.js 10 or Next.js 11.
https://docs.sentry.io/platforms/javascript/guides/nextjs/manual-setup/

  • Feature

@james-wallis james-wallis changed the title Feature/add sentry Add Sentry Monitoring Apr 12, 2022
@github-actions
Copy link

github-actions bot commented Apr 12, 2022

Reference Apps Deployment

This pull request has been automatically deployed.
To see the status of your deployment, click below or on the icon next to each commit.

✅  GitHub Workflow: https://github.com/ostmodern/skylark-reference-apps/actions/runs/2155100095
🔗  Media: https://media.apps.legacy-skylark-development.skylarkplatform.io

@james-wallis james-wallis changed the title Add Sentry Monitoring Add Sentry Monitoring (and break API routes) Apr 12, 2022
@james-wallis james-wallis merged commit bfd1df3 into main Apr 12, 2022
@james-wallis james-wallis deleted the feature/add-sentry branch April 12, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants