Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-2096] feat: fetch playback url & remove sentry #35

Merged
merged 24 commits into from
Jun 20, 2022

Conversation

jahed04368
Copy link
Contributor

@jahed04368 jahed04368 commented Jun 6, 2022

  • Added an API route to fetch playback URL for episodes & movies
  • Removed sentry from the reference app as it breaks the usage of API routes with serverless-nextjs.
  • Related Skylark PR: https://github.com/ostmodern/skylark/pull/379
  • Feature

Jira

https://ostmodern.atlassian.net/browse/SL-2096

Self-review

  • Changes self-reviewed

Practical Tests Performed (Author)

  • < Fill this in or "None" >

Practical Tests Performed (Reviewer)

  • < Fill this in or "None" >

Automated Testing

  • Appropriate unit/regression/integration tests
  • Tests for negative cases

@jahed04368 jahed04368 changed the title fetch playback url & remove sentry [SL-2096] feat: fetch playback url & remove sentry Jun 6, 2022
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Reference Apps Deployment

This pull request has been automatically deployed.
To see the status of your deployment, click below or on the icon next to each commit.

✅  GitHub Workflow: https://github.com/ostmodern/skylark-reference-apps/actions/runs/2527933384
🔗  Media: https://media.feature-sl-2096-fetch-playbackurl-and-remove-sentry.apps.legacy-skylark-development.skylarkplatform.io

@jahed04368 jahed04368 marked this pull request as ready for review June 6, 2022 11:29
@jahed04368 jahed04368 requested a review from a team as a code owner June 6, 2022 11:29
@jahed04368 jahed04368 requested a review from james-wallis June 6, 2022 11:29
@james-wallis
Copy link
Collaborator

Also please remove useServerlessTraceTarget from packages/infra/bin/infra.ts.

It was added in #5 (comment) for Senty support and also seems to break API routes.

@jahed04368 jahed04368 requested a review from james-wallis June 13, 2022 14:18
Copy link
Collaborator

@james-wallis james-wallis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this. Need to change the skylark deploy showcase workflow to have these new credentials (we can pair this):

cognito-aws-region: ${{ secrets.NEXT_PUBLIC_COGNITO_AWS_REGION }}
          cognito-client-id: ${{ secrets.NEXT_PUBLIC_COGNITO_CLIENT_ID }}
          cognito-user-pool-id: ${{ secrets.NEXT_PUBLIC_COGNITO_USER_POOL_ID }}
          cognito-identity-pool-id: ${{ secrets.NEXT_PUBLIC_COGNITO_IDENTITY_POOL_ID }}
          cognito-email: ${{ secrets.COGNITO_EMAIL }}
          cognito-password: ${{ secrets.COGNITO_PASSWORD }}
          ```

@james-wallis james-wallis merged commit d234019 into main Jun 20, 2022
@james-wallis james-wallis deleted the feature/SL-2096-fetch_playbackurl_and_remove_sentry branch June 20, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants