-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SL-2096] feat: fetch playback url & remove sentry #35
[SL-2096] feat: fetch playback url & remove sentry #35
Conversation
Reference Apps DeploymentThis pull request has been automatically deployed. ✅ GitHub Workflow: https://github.com/ostmodern/skylark-reference-apps/actions/runs/2527933384 |
Also please remove It was added in #5 (comment) for Senty support and also seems to break API routes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this. Need to change the skylark
deploy showcase workflow to have these new credentials (we can pair this):
cognito-aws-region: ${{ secrets.NEXT_PUBLIC_COGNITO_AWS_REGION }}
cognito-client-id: ${{ secrets.NEXT_PUBLIC_COGNITO_CLIENT_ID }}
cognito-user-pool-id: ${{ secrets.NEXT_PUBLIC_COGNITO_USER_POOL_ID }}
cognito-identity-pool-id: ${{ secrets.NEXT_PUBLIC_COGNITO_IDENTITY_POOL_ID }}
cognito-email: ${{ secrets.COGNITO_EMAIL }}
cognito-password: ${{ secrets.COGNITO_PASSWORD }}
```
… github.com:ostmodern/skylark-reference-apps into feature/SL-2096-fetch_playbackurl_and_remove_sentry
…ttps://github.com/ostmodern/skylark-reference-apps into feature/SL-2096-fetch_playbackurl_and_remove_sentry
sentry
from the reference app as it breaks the usage of API routes withserverless-nextjs
.Jira
https://ostmodern.atlassian.net/browse/SL-2096
Self-review
Practical Tests Performed (Author)
Practical Tests Performed (Reviewer)
Automated Testing