Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add two more levels #309 #311

Merged
merged 2 commits into from
Sep 13, 2024
Merged

add two more levels #309 #311

merged 2 commits into from
Sep 13, 2024

Conversation

sroertgen
Copy link
Contributor

Added two more levels as discussed in #309

@LasseMempel would you mind testing out?

cc @acka47

@LasseMempel
Copy link

It seems to be supporting 6 levels at the moment, if I am not mistaken we were targeting at least 7?
I attached the resulting hierarchy up to "Röntgenuntersuchung" and a section of the turtle file with two concepts containing "Röntgenuntersuchung" as skos:broader.

Screenshot 2024-09-04 102212
Screenshot 2024-09-04 101803

The repository is: https://github.com/LasseMempel/RestSkos-pages
You can find the turtle file here: https://github.com/LasseMempel/RestSkos-pages/blob/main/skosifyCSV/fixedData.ttl

Thank you for your work!

@sroertgen
Copy link
Contributor Author

Thanks for testing. Seems like we need yet another level. Added it and tested with your vocab. I now have two narrower concepts:
grafik

@sroertgen sroertgen linked an issue Sep 4, 2024 that may be closed by this pull request
acka47 added a commit to acka47/testing-skohub-vocabs that referenced this pull request Sep 12, 2024
@acka47
Copy link
Member

acka47 commented Sep 12, 2024

Sorry, I forgot this PR. We definitely need to restart some regular meeting to go through the Kanban board...

I also tested this PR with the vocab from https://github.com/LasseMempel/RestSkos-pages/blob/main/skosifyCSV/fixedData.ttl. The build works and the result is at https://test.skohub.io/acka47/testing-skohub-vocabs/heads/master/leiza.de/thesaurus.html. All levels seem to be covered, thus, this can be deployed.

Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@acka47 acka47 assigned Phu2 and unassigned acka47 and sroertgen Sep 12, 2024
@acka47
Copy link
Member

acka47 commented Sep 12, 2024

I assigned this to @Phu2 so that he can merge and deploy the latest version at skohub.io, right?

@sroertgen
Copy link
Contributor Author

Sorry, I forgot this PR. We definitely need to restart some regular meeting to go through the Kanban board...

I also tested this PR with the vocab from https://github.com/LasseMempel/RestSkos-pages/blob/main/skosifyCSV/fixedData.ttl. The build works and the result is at https://test.skohub.io/acka47/testing-skohub-vocabs/heads/master/leiza.de/thesaurus.html. All levels seem to be covered, thus, this can be deployed.

yes, we should do that. or maybe do it as a community call and we use metadata.community to announce it?

@sroertgen
Copy link
Contributor Author

I will merge now and deployment is automatically since new vocabs will be built with the new container version.

@sroertgen sroertgen merged commit a86f954 into main Sep 13, 2024
3 checks passed
@sroertgen sroertgen deleted the 309-deeper-hierarchy branch September 13, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

Need for even deeper hierarchy level
4 participants