-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add two more levels #309 #311
Conversation
It seems to be supporting 6 levels at the moment, if I am not mistaken we were targeting at least 7? The repository is: https://github.com/LasseMempel/RestSkos-pages Thank you for your work! |
Sorry, I forgot this PR. We definitely need to restart some regular meeting to go through the Kanban board... I also tested this PR with the vocab from https://github.com/LasseMempel/RestSkos-pages/blob/main/skosifyCSV/fixedData.ttl. The build works and the result is at https://test.skohub.io/acka47/testing-skohub-vocabs/heads/master/leiza.de/thesaurus.html. All levels seem to be covered, thus, this can be deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I assigned this to @Phu2 so that he can merge and deploy the latest version at skohub.io, right? |
yes, we should do that. or maybe do it as a community call and we use metadata.community to announce it? |
I will merge now and deployment is automatically since new vocabs will be built with the new container version. |
Added two more levels as discussed in #309
@LasseMempel would you mind testing out?
cc @acka47