Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for even deeper hierarchy level #309

Closed
LasseMempel opened this issue Jun 17, 2024 · 6 comments · Fixed by #311
Closed

Need for even deeper hierarchy level #309

LasseMempel opened this issue Jun 17, 2024 · 6 comments · Fixed by #311
Assignees

Comments

@LasseMempel
Copy link

The thesaurus I am working with has two deeper hierarchy levels than currently supported.
Any chance there is space for these? Or to avoid future issues of the same type a limitless (to a certain degree) nesting support?

@acka47 acka47 added this to SkoHub Jun 17, 2024
@github-project-automation github-project-automation bot moved this to Backlog in SkoHub Jun 17, 2024
@acka47
Copy link
Member

acka47 commented Jun 17, 2024

Thanks for the request, @LasseMempel. This is similar to #156 where we already added support for additional hierarchies.

@sroertgen
Copy link
Contributor

Hey @LasseMempel ,

limitless is difficult due to the fact that graphql does not support recursion. But two more levels should be no problem.

@acka47 so should we just add two more levels?

Maybe at some point in the future we can think about restructuring the graphql queries to allow limitless levels

@LasseMempel
Copy link
Author

Two more levels would be a nice start ;)

@acka47 acka47 moved this from Backlog to Ready in SkoHub Aug 7, 2024
@acka47
Copy link
Member

acka47 commented Aug 7, 2024

@acka47 so should we just add two more levels?

+1

sroertgen added a commit that referenced this issue Sep 4, 2024
@sroertgen
Copy link
Contributor

@LasseMempel sorry for the delay. I was on parental leave and did not open my laptop too much.

I added two more levels on branch https://github.com/skohub-io/skohub-vocabs/tree/309-deeper-hierarchy and opened #311

@LasseMempel
Copy link
Author

No worries, I'm glad to hear you're investing in your family!

@sroertgen sroertgen linked a pull request Sep 4, 2024 that will close this issue
sroertgen added a commit that referenced this issue Sep 13, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in SkoHub Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants