Add validation step against skohub.shacl.ttl #14
Assignees
Comments
sroertgen
added a commit
that referenced
this issue
Jan 29, 2024
sroertgen
added a commit
that referenced
this issue
Jan 29, 2024
Action should run on every push not depending on branch
sroertgen
added a commit
that referenced
this issue
Jan 29, 2024
sroertgen
added a commit
that referenced
this issue
Jan 29, 2024
sroertgen
added a commit
that referenced
this issue
Jan 29, 2024
sroertgen
added a commit
that referenced
this issue
Jan 29, 2024
sroertgen
added a commit
that referenced
this issue
Jan 29, 2024
sroertgen
added a commit
that referenced
this issue
Jan 29, 2024
sroertgen
added a commit
that referenced
this issue
Jan 29, 2024
sroertgen
added a commit
that referenced
this issue
Jan 30, 2024
sroertgen
added a commit
that referenced
this issue
Jan 30, 2024
|
After starting to work on skohub-io/skohub-vocabs#289 I noticed that we could skip the validation here at all since it is already validated in SkoHub Vocab and soon even better if we do validation after enrichment of skos:properties. |
sroertgen
added a commit
that referenced
this issue
Jan 30, 2024
SkoHub Vocabs will already validate the vocabularys.
sroertgen
added a commit
that referenced
this issue
Jan 30, 2024
* Use skohub shape to validate data * Revert "Use skohub shape to validate data" This reverts commit 2cec370. * Use skohub shape to validate data #14 * Remove branches from github action #14 Action should run on every push not depending on branch * Update changed files action version #14 * Run on changes of github action file (e.g. main.yml) #15 * Separate changed file action to find ttl and yml files #15 * WIP validate files with skohub shape #14 * WIP fix github environment variable * WIP cat output to see why riot cries #14 * WIP disable workflow #14 * WIP Use pwd for providing full path in mount #14 * WIP Invalidate file for test purposes #14 * WIP cat out testfile #14 * WIP add riot validation step before validating with shacl #14 * WIP clean up a bit #14 * WIP reenable cleanup #14 * WIP GitHub Action not finding testfile. VMs is teared down anyway so its ok * WIP use correct SPARQL query to query result. We are checking for warning and violations * WIP Adjust path to query #14 * WIP Check only for violations. Warning are also present in the SkoHub Vocabs output * WIP make skos file valid turtle, but not valid skos for test purposes * WIP test new matrix preparation * WIP check for yml and ttl files in prepare matrix step #14 * WIP parse json output with jq #14 * WIP Testing: Just change a ttl file * WIP Test: Just change README * Cleanup #14 * Remove validation step #14 SkoHub Vocabs will already validate the vocabularys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I interpret this correctly, there is currently no validation in the docker version against the skohub SHACL shape (https://github.com/skohub-io/shapes/blob/main/skohub.shacl.ttl).
Background: I just had some students trying to built their SKOS vocab with SkoHub and it did not work because
skos:hasTopConceptwas missing – though the inverseskos:topConceptOfis present. The was also validated as correct by https://skos-play.sparna.fr/skos-testing-tool/ . S0 they did a good job but were frustrated by SkoHub not building the vocab and not giving any error message as of why it would not build.(I built the vocab on the skohub.io server which helped me in finding the error as the server version validates against
skohub.shacl.ttand, thus, I got back an error message.)So we should:
1.) Add the validaton step to the docker version
2.) Also think about making it sufficient to use one of two inverse properties
skos:topConceptOforskos:hasTopConcept. (I think we already do this withskos:broader/skos:barrower, dont't we? We'd need another ticket for this in the skohub-vocabs repo. Edit: Here it is: skohub-io/skohub-vocabs#289)The text was updated successfully, but these errors were encountered: