Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14 validate against skohub shacl #16

Merged
merged 29 commits into from
Jan 30, 2024
Merged

Conversation

sroertgen
Copy link
Contributor

@sroertgen sroertgen commented Jan 30, 2024

Vocabularies are now validated for valid turtle and against the skohub shape.
Validation is now removed
See: #14 (comment)

The vocabulary now gets rebuild for changes in the ttl- or yml-files.

Closes #14
Closes #15

Action should run on every push not depending on branch
@sroertgen sroertgen self-assigned this Jan 30, 2024
SkoHub Vocabs will already validate the vocabularys.
Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 It works! However, if we could automatically set the env variables based on the repo's name and URL a vocab is published from, this fix might not be so important after all. I guess, we should next time take some more time to analyze and discuss such irritations and usage problems and how to best solve them before starting the implementation.

@acka47 acka47 removed their assignment Jan 30, 2024
@sroertgen sroertgen merged commit 948f28c into main Jan 30, 2024
4 checks passed
@sroertgen sroertgen deleted the 14-validate-against-skohub-shacl branch January 30, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Adjust GitHub action to rebuild vocab with every change Add validation step against skohub.shacl.ttl
2 participants