Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support usage of topConceptOf without hasTopConcept #289

Closed
acka47 opened this issue Jan 28, 2024 · 1 comment · Fixed by #290
Closed

Support usage of topConceptOf without hasTopConcept #289

acka47 opened this issue Jan 28, 2024 · 1 comment · Fixed by #290
Assignees

Comments

@acka47
Copy link
Member

acka47 commented Jan 28, 2024

From skohub-io/skohub-pages#14 :

Background: I just had some students trying to built their SKOS vocab with SkoHub and it did not work because skos:hasTopConcept was missing – though the inverse skos:topConceptOf is present. The was also validated as correct by https://skos-play.sparna.fr/skos-testing-tool/ . S0 they did a good job but were frustrated by SkoHub not building the vocab and not giving any error message as of why it would not build.
...
So we should (...) think about making it sufficient to use one of two inverse properties skos:topConceptOf or skos:hasTopConcept. (I think we already do this with skos:broader/skos:barrower, dont't we?)

@acka47 acka47 added this to SkoHub Jan 28, 2024
@acka47 acka47 moved this to Backlog in SkoHub Jan 29, 2024
@acka47 acka47 moved this from Backlog to Ready in SkoHub Jan 29, 2024
@acka47
Copy link
Member Author

acka47 commented Jan 29, 2024

This is already supported but the validation is done before this enrichment of inverse properties and, thus, the process is stopped before inverse properties are added.

@sroertgen sroertgen moved this from Ready to Working in SkoHub Jan 30, 2024
sroertgen added a commit that referenced this issue Jan 30, 2024
@sroertgen sroertgen linked a pull request Jan 30, 2024 that will close this issue
@sroertgen sroertgen moved this from Working to Review in SkoHub Jan 30, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in SkoHub Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants